Skip to content

Bug 1733806: Avoid runtime errors checking quota when processing template #3140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2019
Merged

Bug 1733806: Avoid runtime errors checking quota when processing template #3140

merged 1 commit into from
Jul 29, 2019

Conversation

spadgett
Copy link
Member

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 28, 2019
@openshift-ci-robot
Copy link

@spadgett: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

[WIP] Bug 1733806: Avoid runtime errors checking quota when processing template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 28, 2019
@spadgett spadgett mentioned this pull request Jul 28, 2019
Closed
@spadgett spadgett changed the title [WIP] Bug 1733806: Avoid runtime errors checking quota when processing template Bug 1733806: Avoid runtime errors checking quota when processing template Jul 28, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 28, 2019
@spadgett
Copy link
Member Author

/assign @rhamilto

rhamilto
rhamilto reviewed Jul 29, 2019
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2019
@openshift-merge-robot openshift-merge-robot merged commit 8cd8bd0 into openshift:enterprise-3.11 Jul 29, 2019
@openshift-ci-robot
Copy link

@spadgett: All pull requests linked via external trackers have merged. The Bugzilla bug has been moved to the MODIFIED state.

In response to this:

Bug 1733806: Avoid runtime errors checking quota when processing template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett deleted the template-error branch July 29, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rhamilto rhamilto rhamilto left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@rhamilto rhamilto

Labels
bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to provision an OpenShift template from UI, when the CustomResource object in the OpenShift template has "spec.template" as a property defined
4 participants
@spadgett @openshift-ci-robot @rhamilto @openshift-merge-robot