Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds that reference invalid imagestreamtags should be noted. #2957

Open
bparees opened this issue Jun 8, 2015 · 8 comments
Open

Builds that reference invalid imagestreamtags should be noted. #2957

bparees opened this issue Jun 8, 2015 · 8 comments
Assignees
Labels
area/usability component/cli component/web kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/P3

Comments

@bparees
Copy link
Contributor

bparees commented Jun 8, 2015

osc describe and the web ui should give an indication if a BuildConfig uses a From reference to an imagestreamtag that cannot be resolved.

This could be because the imagestream doesn't exist, or because the tag doesn't exist within the imagestream.

Both are technically valid (you could be planning to create the imagestream or tag later) but it'd be good to be warned of it.

@smarterclayton fyi.

@liggitt
Copy link
Contributor

liggitt commented Jun 8, 2015

That would require the web UI to fetch every ImageStreamTag individually. Also, since those can reference things in other namespaces, it would require the viewing user to have permissions in those namespaces. For cross-namespace build sources, it is likely permission will only have been given to the current namespace's service accounts (or even more narrowly, the builder service account), and the viewing user won't have permission to see if it exists.

@smarterclayton
Copy link
Contributor

We probably have to do this to be a good product. It's just not easy.

----- Original Message -----

That would require the web UI to fetch every ImageStreamTag individually.
Also, since those can reference things in other namespaces, it would require
the viewing user to have permissions in those namespaces. For
cross-namespace build sources, it is likely permission will only have been
given to the current namespace's service accounts (or even more narrowly,
the builder service account), and the viewing user won't have permission to
see if it exists.


Reply to this email directly or view it on GitHub:
#2957 (comment)

@jwforres
Copy link
Member

jwforres commented Nov 7, 2016

@bparees is this being done at all today as part of the API or CLI?

@bparees
Copy link
Contributor Author

bparees commented Nov 7, 2016

@jwforres if it's done anywhere, it might be done in oc status, @gabemontero would know, but it's not done in oc describe and it's definitely not part of the api.

@gabemontero
Copy link
Contributor

This is what oc status provides.

At first blush I believe it covers what is in this issue's description. But as alluded to, not part of the api.

@bparees bparees self-assigned this Feb 2, 2018
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 4, 2018
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 3, 2018
@bparees
Copy link
Contributor Author

bparees commented Jun 3, 2018

/remove-lifecycle rotten
/lifecycle frozen

@openshift-ci-robot openshift-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jun 3, 2018
@openshift-ci-robot openshift-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/enhancement labels Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/usability component/cli component/web kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/P3
Projects
None yet
Development

No branches or pull requests

7 participants