Remove the excluders origin-excluder #13387
Conversation
|
@tdawson PTAL, does this make sense, can you remember why we included them in the package list in origin? |
|
It's because in origin, there was only one repo with all versions in it. So if the excluders weren't excluded, then when a new excluder would come along, it would update itself, possibly allowing older versions of docker to be installed. |
|
If we do 3.6 in another repo do you think it's safe to merge this now given
1.4 and 1.5 will both use docker 1.12?
…On Mar 14, 2017 7:54 PM, "Troy Dawson" ***@***.***> wrote:
It's because in origin, there was only one repo with all versions in it.
So if the excluders weren't excluded, then when a new excluder would come
along, it would update itself, possibly allowing older versions of docker
to be installed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#13387 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAC8IShR5Jy5QeUNnUlkDlki9nqCRJmqks5rlyiygaJpZM4MdH_I>
.
|
|
Yes I do |
|
[test] |
|
Evaluated for origin test up to 30653b3 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/223/) (Base Commit: 41a0dbd) |
|
[merge] |
|
Does this need backport? Or no |
|
@smarterclayton it's in ose already, backported to release-1.5 here #13402 |
|
flake #13271 |
|
flake #13318 |
|
flake #13271 |
|
flaked on something in origin-gce |
|
Evaluated for origin merge up to 30653b3 |
|
continuous-integration/openshift-jenkins/merge FAILURE (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/113/) (Base Commit: bbf6d90) |
|
flake #12007 |
|
This is blocking merge queues, has been merged into ose forever and is merged into release-1.5 already. |
I don't recall why we included the excluders in origin-excluder package list in origin but not OSE, but this is breaking the upgrade playbooks.