-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add defaulting NAMESPACE and OPENSHIFT_USERNAME parameters #16021
Add defaulting NAMESPACE and OPENSHIFT_USERNAME parameters #16021
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jim-minter Assign the PR to them by writing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
@bparees @openshift/api-review ptal Requirement: capability to substitute current namespace and username into templates at instantiation time without having to specify values manually. It's proposed only to implement this on the TemplateInstance API, not the back-end of There are at least a couple of potential approaches here:
Some pros and cons:
@openshift/api-review, wdyt? |
(2) is also incompatible w/ a non-service-catalog(tsb) based web console template provision flow. |
I think we have to be hard compatible - i.e. someone has to ask for these to be special replaced. I don't like "OPENSHIFT" existing in the name. These really sound like generators, if we do them. What things need namespace (I.e. list use cases for namespace and username here)? We've said upstream that certain things should always be done via downwards API. Knowing what is not covered by downwards API is good. |
@smarterclayton |
On Aug 28, 2017, at 6:23 PM, Jim Minter <notifications@github.com> wrote:
@smarterclayton <https://github.com/smarterclayton>
in #8971 <#8971> @sosiouxme
<https://github.com/sosiouxme> wanted to refer to a service account in the
template namespace in a ClusterRoleBinding
And passing a namespace param is insufficient?
in #13934 <#13934> it was wanted
for a DeploymentConfig imagechange trigger to refer to a imagestream in the
"current" namespace. Perhaps the template was creating a DC in a second
namespace and wanted to refer back?
For namespace, it seems like it's convenience, not strictly required.
Since the bar is so high for template features, are there any examples
where a user providing the namespace is impossible?
in https://bugzilla.redhat.com/show_bug.cgi?id=1331268 two customers wanted
to set the Route name to include the "current" namespace, but not according
to the way we autogenerate it.
Why not fix routes to support single segment hostnames?
in https://bugzilla.redhat.com/show_bug.cgi?id=1445146 a customer wanted
the current user to be able to customise configuration deployed by the
template, e.g. have the deployed app configured to email updates to the
deploying user.
Email wouldn't work unless they had username as email, which not everyone
does. Other examples here?
|
https://trello.com/c/zcRQFri0/916-3-namespace-template-parameter-templates
https://trello.com/c/PecTGTlj/1208-3-username-template-parameter-templates
https://bugzilla.redhat.com/show_bug.cgi?id=1331268
https://bugzilla.redhat.com/show_bug.cgi?id=1445146
#8971