-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport metrics fixes #16266
Backport metrics fixes #16266
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/retest |
/unassign |
UPSTREAM: 49117: Add apiserver metric for response sizes split by namespace scope UPSTREAM: 49678: Report non-resource URLs in max-in-flight correctly UPSTREAM: 49678: Timeout filter returns 504 and an inconsistent error body UPSTREAM: 50123: Report pod logs as CONNECT in metrics UPSTREAM: 52237: Add scope to all apiserver metrics and report resource scope
45e0300
to
3959bdc
Compare
changes look fine, reason for squashing to a single commit? |
Cherry pick was easier because the script cant (today) handle creating individual commits, it creates a patch from a range and rebases onto our upstream commit |
/test all [submit-queue is verifying that this PR is safe to merge] |
@smarterclayton: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Automatic merge from submit-queue (batch tested with PRs 16362, 16266) |
Fixes #16208
This needs to be in the next release drop
UPSTREAM: 48583: Record 429 and timeout errors to prometheus
UPSTREAM: 49117: Add apiserver metric for response sizes split by namespace scope
UPSTREAM: 49678: Report non-resource URLs in max-in-flight correctly
UPSTREAM: 49678: Timeout filter returns 504 and an inconsistent error body
UPSTREAM: 50123: Report pod logs as CONNECT in metrics
UPSTREAM: 52237: Add scope to all apiserver metrics and report resource scope