Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip oc version test in disconnected #26655

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Skip oc version test in disconnected #26655

merged 1 commit into from
Nov 30, 2021

Conversation

ardaguclu
Copy link
Member

[sig-cli] oc version check kubernetes version matches the io.openshift.build.versions label
test tries to exec oc image info command in master nodes to compare
versions.

However, in disconnected configuration, this command can not access registry by
throwing network is unreachable.

This PR skips this test in disconnected.

@ardaguclu
Skip oc version test in disconnected
2a2e6c9 
`[sig-cli] oc version check kubernetes version matches the io.openshift.build.versions label`
test tries to exec `oc image info` command in master nodes to compare
versions.

However, in disconnected configuration, this command can not access registry by
throwing `network is unreachable`.

This PR skips this test in disconnected.
@ardaguclu
Copy link
Member Author

/test e2e-metal-ipi-ovn-ipv6

@ardaguclu
Copy link
Member Author

/test e2e-aws-proxy

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2021

@ardaguclu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node 2a2e6c9 link false /test e2e-aws-single-node
ci/prow/e2e-aws-proxy 2a2e6c9 link false /test e2e-aws-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ardaguclu
Copy link
Member Author

e2e-aws-proxy is also perm failing but it is not a release blocker.

@dgoodwin
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2021
soltysh
soltysh approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, dgoodwin, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2021
@openshift-merge-robot openshift-merge-robot merged commit 3c3599a into openshift:master Nov 30, 2021
@hardys hardys mentioned this pull request Nov 30, 2021
Merged
@stbenjam stbenjam mentioned this pull request Dec 1, 2021
Merged
@ardaguclu ardaguclu deleted the skip-oc-version-disconnected branch January 25, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@dmage dmage Awaiting requested review from dmage

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@dgoodwin dgoodwin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ardaguclu @dgoodwin @soltysh @openshift-merge-robot