use standard disruption checker for load balancer #26703
Conversation
openshift-ci
bot
added
the
approved
…icitly by test name to namespace name indirection
|
/payload 4.10 ci blocking /hold holding so we can see the payload results. I think this will actually reduce the downtime observed for service LB because it's more likely to end up as one second chunks. |
openshift-ci
bot
added
the
do-not-merge/hold
|
@deads2k: trigger 5 jobs of type blocking for the ci release of OCP 4.10
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/025647f0-5ea0-11ec-9f3b-36fac19126d7-0 trigger 7 jobs of type blocking for the nightly release of OCP 4.10
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/025647f0-5ea0-11ec-9f3b-36fac19126d7-1 |
| @@ -198,6 +198,10 @@ func (b *BackendSampler) bodyMatches(body []byte) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (b *BackendSampler) SetHost(host string) { | |||
| b.host = host | |||
| } | |||
There was a problem hiding this comment.
Is breaking the "With" pattern above intentional due to the late binding nature of it?
There was a problem hiding this comment.
Is breaking the "With" pattern above intentional due to the late binding nature of it?
yes
|
/retest |
|
4.9 doesn't honor the scc label. I'll have to tweak the namespace too. Oh teh ugly. |
|
/payload 4.10 ci blocking |
|
@deads2k: trigger 5 jobs of type blocking for the ci release of OCP 4.10
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fcb5db20-5eb9-11ec-8e0e-d22bca274e87-0 trigger 7 jobs of type blocking for the nightly release of OCP 4.10
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fcb5db20-5eb9-11ec-8e0e-d22bca274e87-1 |
|
/payload 4.10 ci blocking /retest |
|
@deads2k: trigger 5 jobs of type blocking for the ci release of OCP 4.10
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3e0d85e0-5ee8-11ec-8f15-cd3fe5423333-0 trigger 7 jobs of type blocking for the nightly release of OCP 4.10
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3e0d85e0-5ee8-11ec-8f15-cd3fe5423333-1 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, dgoodwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
no conflict with previous. merging. |
replaces #26675, built on #26682