Skip to content

TRT-1854: remove upstream annotation framework #30305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2025
Merged

TRT-1854: remove upstream annotation framework #30305

merged 2 commits into from
Oct 1, 2025
+8 −14,093

Conversation

smg247
Copy link
Member

@smg247 smg247 commented Sep 25, 2025

Filtering out the upstream k8s tests via CodeLocations allows us to remove our dependency on the annotation framework. I considered doing this check via regex, but the strings.Contains is more legible.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 25, 2025 •
edited by openshift-ci bot
Loading

@smg247: This pull request references TRT-1854 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Filtering out the upstream k8s tests via CodeLocations allows us to remove our dependency on the annotation framework. I considered doing this check via regex, but the strings.Contains is more legible.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 25, 2025
@smg247
Copy link
Member Author

smg247 commented Sep 25, 2025

/hold I don't want to merge this until its predecessor has been in for a while

@openshift-ci openshift-ci bot added vendor-update Touching vendor dir or related files do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 25, 2025
@smg247
Copy link
Member Author

smg247 commented Sep 25, 2025

/retest

@smg247
Copy link
Member Author

smg247 commented Sep 26, 2025

/retest-required

@smg247 smg247 mentioned this pull request Sep 26, 2025
Open
@smg247
Copy link
Member Author

smg247 commented Sep 29, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2025
sosiouxme
sosiouxme approved these changes Sep 29, 2025
View reviewed changes
Copy link
Member

@sosiouxme sosiouxme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smg247, sosiouxme

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smg247
Copy link
Member Author

smg247 commented Sep 29, 2025

/verified bypass

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 29, 2025
@openshift-ci-robot
Copy link

@smg247: The verified label has been added.

In response to this:

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c49344f and 2 for PR HEAD 0fe3840 in total

@smg247
Copy link
Member Author

smg247 commented Sep 30, 2025

/retest-required

3 similar comments
@sosiouxme
Copy link
Member

/retest-required

@sosiouxme
Copy link
Member

/retest-required

@smg247
Copy link
Member Author

smg247 commented Sep 30, 2025

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 30, 2025 •
edited
Loading

@smg247: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-edge-zones 0fe3840 link false /test e2e-aws-ovn-edge-zones
ci/prow/e2e-gcp-csi 0fe3840 link false /test e2e-gcp-csi
ci/prow/e2e-aws-ovn-single-node 0fe3840 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-csi 0fe3840 link false /test e2e-aws-csi
ci/prow/okd-scos-e2e-aws-ovn 0fe3840 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-openstack-ovn 0fe3840 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-single-node-upgrade 0fe3840 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt openshift-trt
Copy link

openshift-trt bot commented Sep 30, 2025

Job Failure Risk Analysis for sha: 0fe3840

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-csi IncompleteTests
Tests for this run (106) are below the historical average (1356): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-2of2 IncompleteTests
Tests for this run (25) are below the historical average (1378): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-csi IncompleteTests
Tests for this run (107) are below the historical average (1623): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@sosiouxme
Copy link
Member

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit 11244cf into openshift:main Oct 1, 2025
23 of 30 checks passed
@jsafrane jsafrane mentioned this pull request Oct 3, 2025
Merged
jsafrane added a commit to jsafrane/release that referenced this pull request Oct 3, 2025
@jsafrane
Make the CSi driver jobs mandatory for origin PRs
7b2110e 
There were several PRs that have broken CSI tests, the last one openshift/origin#30305
@jsafrane jsafrane mentioned this pull request Oct 3, 2025
Merged
jsafrane added a commit to jsafrane/release that referenced this pull request Oct 3, 2025
@jsafrane
Make the CSi driver jobs mandatory for origin PRs
03ce3ee 
There were several PRs that have broken CSI tests, the last one openshift/origin#30305
openshift-merge-bot bot pushed a commit to openshift/release that referenced this pull request Oct 3, 2025
@jsafrane
Make the CSi driver jobs mandatory for origin PRs (#69952)
a3c4c0c 
There were several PRs that have broken CSI tests, the last one openshift/origin#30305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosiouxme sosiouxme sosiouxme approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

Assignees

@sosiouxme sosiouxme

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files verified Signifies that the PR passed pre-merge verification criteria
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smg247 @openshift-ci-robot @sosiouxme