Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable 4.6 to 4.7 upgrade testing of the GPU Operator master branch #18146

Merged
merged 2 commits into from
May 11, 2021
Merged

Enable 4.6 to 4.7 upgrade testing of the GPU Operator master branch #18146

merged 2 commits into from
May 11, 2021

Conversation

kpouget
Copy link
Contributor

@kpouget kpouget commented Apr 28, 2021 •
edited
Loading

The PR to allow OpenShift cluster upgrade in the GPU Operator has been merged recently.

With this test, we'll verify that this functionality works as expected.

The testing frequency will be decided later on.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 28, 2021
@openshift-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kpouget

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2021
@kpouget kpouget marked this pull request as ready for review April 28, 2021 15:30
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 28, 2021
@kpouget
Copy link
Contributor Author

kpouget commented Apr 28, 2021

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2021
@kpouget
Copy link
Contributor Author

kpouget commented Apr 29, 2021

test failed because this PR wasn't merged in the GPU Operator. It has been merged during the night.

/test pj-rehearse

@kpouget
Copy link
Contributor Author

kpouget commented Apr 29, 2021

strange

 ERRO[2021-04-29T09:42:18Z] Some steps failed:                           
ERRO[2021-04-29T09:42:18Z]   * could not run steps: step gpu-operator-e2e-upgrade failed: "gpu-operator-e2e-upgrade" test steps failed: "gpu-operator-e2e-upgrade" pod "gpu-operator-e2e-upgrade-2-upgrade" failed: the pod ci-op-lv3phnwi/gpu-operator-e2e-upgrade-2-upgrade was deleted without completing after 1h5m0s (failed containers: )

but the 2-upgrade step finished successfull
https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_release/18146/rehearse-18146-pull-ci-openshift-psap-ci-artifacts-release-4.7-upgrade-gpu-operator-e2e-upgrade/1387667522689437696/artifacts/gpu-operator-e2e-upgrade/2-upgrade/finished.json

/test pj-rehearse

@kpouget
Copy link
Contributor Author

kpouget commented Apr 29, 2021

yes, the upgrade from 4.6 to 4.7 worked !
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/18146/rehearse-18146-pull-ci-openshift-psap-ci-artifacts-release-4.7-upgrade-gpu-operator-e2e-upgrade/1387705408407212032

now I need to find out how to properly integrate it in the CI configuration, and how often we test it

@kpouget kpouget mentioned this pull request Apr 29, 2021
Closed
@kpouget
Copy link
Contributor Author

kpouget commented Apr 29, 2021

Part of openshift-psap/ci-artifacts#105

@kpouget
Copy link
Contributor Author

kpouget commented May 4, 2021

/test pj-rehearse

2 similar comments
@kpouget
Copy link
Contributor Author

kpouget commented May 5, 2021

/test pj-rehearse

@kpouget
Copy link
Contributor Author

kpouget commented May 5, 2021

/test pj-rehearse

@kpouget
Copy link
Contributor Author

kpouget commented May 6, 2021

another typo, should be fixed by openshift-psap/ci-artifacts#146

/test pj-rehearse

@kpouget
Copy link
Contributor Author

kpouget commented May 6, 2021 via email

@kpouget
Copy link
Contributor Author

kpouget commented May 6, 2021 via email

@kpouget
Copy link
Contributor Author

kpouget commented May 6, 2021

/test pj-rehearse

@kpouget
Copy link
Contributor Author

kpouget commented May 6, 2021

@dagrayvid this one is ready for merging,

it tests every Wednesday at noon the cluster upgrade (4.6 -> 4.7) with the GPU Operator installed from master
(I couldn't keep my comment on the cron job :#)

@kpouget
Copy link
Contributor Author

kpouget commented May 6, 2021

wait, no, I need to enable slack reporting ...
/hold

@kpouget
Copy link
Contributor Author

kpouget commented May 6, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2021
@kpouget
Copy link
Contributor Author

kpouget commented May 7, 2021

/test pj-rehearse

@dagrayvid
Copy link
Contributor

Thanks,
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dagrayvid, kpouget

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7639e86 into openshift:master May 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2021

@kpouget: Updated the following 2 configmaps:

  • ci-operator-4.7-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-psap-ci-artifacts-release-4.7.yaml using file ci-operator/config/openshift-psap/ci-artifacts/openshift-psap-ci-artifacts-release-4.7.yaml
    • key openshift-psap-ci-artifacts-release-4.7__upgrade.yaml using file ci-operator/config/openshift-psap/ci-artifacts/openshift-psap-ci-artifacts-release-4.7__upgrade.yaml
  • job-config-4.7 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-psap-ci-artifacts-release-4.7-periodics.yaml using file ci-operator/jobs/openshift-psap/ci-artifacts/openshift-psap-ci-artifacts-release-4.7-periodics.yaml
    • key openshift-psap-ci-artifacts-release-4.7-postsubmits.yaml using file ``
    • key openshift-psap-ci-artifacts-release-4.7-presubmits.yaml using file ci-operator/jobs/openshift-psap/ci-artifacts/openshift-psap-ci-artifacts-release-4.7-presubmits.yaml

In response to this:

The PR to allow OpenShift cluster upgrade in the GPU Operator has been merged recently.

With this test, we'll verify that this functionality works as expected.

The testing frequency will be decided later on.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kpouget kpouget deleted the upgrade branch June 21, 2021 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

@courtneypacheco courtneypacheco Awaiting requested review from courtneypacheco

Assignees

@dagrayvid dagrayvid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kpouget @openshift-ci-robot @dagrayvid @openshift-merge-robot