Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCP Logging: Replace nodejs-10 base image for kibana with ubi8 #27705

Merged

Conversation

syedriko
Copy link
Contributor

@syedriko syedriko commented Apr 8, 2022

OCP Logging: Replace nodejs-10 base image for kibana with ubi8

Links

@syedriko
Copy link
Contributor Author

syedriko commented Apr 8, 2022

There is a circular dependency between this PR and openshift/origin-aggregated-logging#2248. Can we please get this one merged.

@syedriko
Copy link
Contributor Author

/assign @jcantrill

@jcantrill
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, syedriko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2022
@syedriko
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 94553ee into openshift:master Apr 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2022

@syedriko: Updated the ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:

  • key openshift-origin-aggregated-logging-master.yaml using file ci-operator/config/openshift/origin-aggregated-logging/openshift-origin-aggregated-logging-master.yaml

In response to this:

OCP Logging: Replace nodejs-10 base image for kibana with ubi8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2022

@syedriko: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@syedriko syedriko deleted the syedriko_kibana_ubi_base branch April 26, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants