Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[redhat-developer/odo] Remove periodic runs using the aws cluster profile #44645

Merged
merged 2 commits into from
Oct 23, 2023
Merged

[redhat-developer/odo] Remove periodic runs using the aws cluster profile #44645

merged 2 commits into from
Oct 23, 2023

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Oct 20, 2023

Fixes redhat-developer/odo#7111

We are asked to move away from using the aws cluster profile.

As depicted in [1] and as discussed in our community call, it makes sense for odo to remove our periodic Prow runs (the ones that were using the aws cluster profile) as they don't seem to be that useful anyway.
We already have good coverage with the checks that we run on IBM Cloud.

NOTE: only the periodic runs using the aws cluster profile are being removed, not the ones using the aws-cspi-qe cluster profile (which are used for interop tests and managed by a different team).

[1] redhat-developer/odo#7111

@rm3l rm3l changed the title Remove periodic Prow runs for odo [redhat-developer/odo] Remove periodic runs using the aws cluster profile Oct 20, 2023
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 20, 2023
@rm3l rm3l mentioned this pull request Oct 20, 2023
Closed
@openshift-ci openshift-ci bot requested review from feloy and kadel October 20, 2023 08:35
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2023
@rm3l rm3l force-pushed the 7111-disable-periodic-prow-runs--odo branch from 885fc66 to 6ac50fd Compare October 20, 2023 13:35
@rm3l
Remove periodic Prow runs for odo
fa53c35 
We are asked to move away from using the `aws` cluster profile.
As depicted in [1] and as discussed in our community calls, it makes
sense for odo to remove our periodic Prow runs (the ones that were using
the `aws` cluster profile) as they don't seem to be that useful anyway.
We already have good coverage with the checks that we run on IBM Cloud.

[1] redhat-developer/odo#7111

Signed-off-by: Armel Soro <asoro@redhat.com>
@rm3l
Regenerate Prow job configuration with 'make jobs'
3771047 
Signed-off-by: Armel Soro <asoro@redhat.com>
@rm3l rm3l force-pushed the 7111-disable-periodic-prow-runs--odo branch from 6ac50fd to 3771047 Compare October 23, 2023 11:27
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@rm3l: no rehearsable tests are affected by this change

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

@rm3l: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kadel
Copy link
Member

kadel commented Oct 23, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel, rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit d8caa13 into openshift:master Oct 23, 2023
16 checks passed
@rm3l rm3l deleted the 7111-disable-periodic-prow-runs--odo branch October 23, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy Awaiting requested review from feloy

@kadel kadel Awaiting requested review from kadel

Assignees

@kadel kadel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable periodic Prow jobs that make use of the aws cluster profile
3 participants
@rm3l @openshift-ci-robot @kadel