Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade konflux compatibility tasks to 4.14 #52112

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented May 16, 2024

Upgrades the registry tests to point to ocp 4.14. It also removes the konflux-nightly-devfile-compatibility as the current component/application creation process will be deprecated and this test will be not needed.

fixes devfile/api#1535

Signed-off-by: thepetk <thepetk@gmail.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2024
@thepetk
Copy link
Contributor Author

thepetk commented May 16, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@thepetk: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@thepetk
Copy link
Contributor Author

thepetk commented May 22, 2024

/retest

@thepetk
Copy link
Contributor Author

thepetk commented May 22, 2024

/pj-rehearse periodic-ci-devfile-registry-main-v4.14-konflux-nightly-devfile-compatibility

@openshift-ci-robot
Copy link
Contributor

@thepetk: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Signed-off-by: thepetk <thepetk@gmail.com>
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@thepetk: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-devfile-registry-main-v4.14-images devfile/registry presubmit Presubmit changed
pull-ci-devfile-registry-main-v4.14-registry-test devfile/registry presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@thepetk
Copy link
Contributor Author

thepetk commented May 22, 2024

I've updated the PR to remove the konflux-nightly-devfile-compatibility test as the process that the test is following will be deprecated.

@thepetk
Copy link
Contributor Author

thepetk commented May 22, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@thepetk: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@maysunfaisal
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2024
Copy link
Contributor

openshift-ci bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maysunfaisal, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
Copy link
Contributor

openshift-ci bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maysunfaisal, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk
Copy link
Contributor Author

thepetk commented May 23, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@thepetk: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 23, 2024
Copy link
Contributor

openshift-ci bot commented May 23, 2024

@thepetk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-devfile-registry-main-v4.14-konflux-nightly-devfile-compatibility f5ac9ec link unknown /pj-rehearse periodic-ci-devfile-registry-main-v4.14-konflux-nightly-devfile-compatibility

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit bfa9476 into openshift:master May 23, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
3 participants