Update devfile integration tests to OpenShift 4.15 #53140

michael-valdron · 2024-06-12T19:11:41Z

Description

Devfile integration tests will be using golang 1.21 and kubernetes 1.29 after pending changes: devfile/integration-tests#105

blocking devfile/api#1561

michael-valdron · 2024-06-12T19:13:21Z

/pj-rehearse auto-ack

openshift-ci-robot · 2024-06-12T19:13:23Z

@michael-valdron: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

thepetk · 2024-06-13T08:25:43Z

/pj-rehearse periodic-ci-devfile-integration-tests-main-v4.15.console-e2e-aws-console-periodic

openshift-ci-robot · 2024-06-13T08:25:46Z

@thepetk: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

thepetk · 2024-06-13T08:25:50Z

/pj-rehearse pull-ci-devfile-integration-tests-main-v4.15.console-images

openshift-ci-robot · 2024-06-13T08:25:53Z

@thepetk: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

michael-valdron · 2024-06-13T15:38:34Z

/pj-rehearse ack

Existing console checks are failing as well for the past year, given that there is no solution to resolve these at this time though intent on resolving it at a future date we can proceed with adding the OCP 4.15 jobs despite the failing console jobs that we intent to be resolved with the existing ones.

openshift-ci-robot · 2024-06-13T15:38:36Z

@michael-valdron: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

johnmcollier

Why aren't we migrating one of the existing job configs? I don't think we need to keep both 4.10 or 4.12 around

michael-valdron · 2024-06-13T16:02:22Z

Why aren't we migrating one of the existing job configs? I don't think we need to keep both 4.10 or 4.12 around

@johnmcollier we could scrap the oldest 4.10 as I believe its EOL by now.

johnmcollier · 2024-06-13T16:11:01Z

Removing 4.10 would be fine

michael-valdron · 2024-06-13T16:15:38Z

/pj-rehearse

openshift-ci-robot · 2024-06-13T16:15:41Z

@michael-valdron: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

johnmcollier

Left some additional comments. I'm also seeing a lot of references to v4.11 get added in

ci-operator/config/devfile/integration-tests/devfile-integration-tests-main__v4.15.console.yaml

johnmcollier · 2024-06-13T17:14:43Z

ci-operator/jobs/devfile/integration-tests/devfile-integration-tests-main-periodics.yaml

@@ -12,10 +12,10 @@ periodics:
  labels:
    ci-operator.openshift.io/cloud: aws
    ci-operator.openshift.io/cloud-cluster-profile: aws-devfile
-    ci-operator.openshift.io/variant: v4.10.console
+    ci-operator.openshift.io/variant: v4.11.console


@johnmcollier Changes to the jobs are reordered so its changing all of them to the next one up, same result though.

johnmcollier · 2024-06-13T17:15:56Z

ci-operator/jobs/devfile/integration-tests/devfile-integration-tests-main-periodics.yaml

    ci.openshift.io/generator: prowgen
    pj-rehearse.openshift.io/can-be-rehearsed: "true"
-  name: periodic-ci-devfile-integration-tests-main-v4.10.console-e2e-aws-console-periodic
+  name: periodic-ci-devfile-integration-tests-main-v4.11.console-e2e-aws-console-periodic


v4.11? (and same for odo down below)

#53140 (comment)

ci-operator/jobs/devfile/integration-tests/devfile-integration-tests-main-periodics.yaml

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

openshift-ci-robot · 2024-06-13T18:44:50Z

[REHEARSALNOTIFIER]
@michael-valdron: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-devfile-integration-tests-main-v4.15.console-images	devfile/integration-tests	presubmit	Presubmit changed
pull-ci-devfile-integration-tests-main-v4.15.odo-images	devfile/integration-tests	presubmit	Presubmit changed
periodic-ci-devfile-integration-tests-main-v4.15.console-e2e-aws-console-periodic	N/A	periodic	Periodic changed
periodic-ci-devfile-integration-tests-main-v4.15.odo-integration-devfile-odo-periodic	N/A	periodic	Periodic changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

michael-valdron · 2024-06-13T18:46:01Z

/pj-rehearse

openshift-ci-robot · 2024-06-13T18:46:03Z

@michael-valdron: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

michael-valdron · 2024-06-13T20:04:24Z

/pj-rehearse ack

openshift-ci-robot · 2024-06-13T20:04:26Z

@michael-valdron: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

johnmcollier

/lgtm
/approve

openshift-ci · 2024-06-13T23:34:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~ci-operator/config/devfile/integration-tests/OWNERS~~ [johnmcollier,michael-valdron]
~~ci-operator/jobs/devfile/integration-tests/OWNERS~~ [johnmcollier,michael-valdron]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2024-06-13T23:49:12Z

@michael-valdron: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/periodic-ci-devfile-integration-tests-main-v4.15.console-e2e-aws-console-periodic	`41c1005`	link	unknown	`/pj-rehearse periodic-ci-devfile-integration-tests-main-v4.15.console-e2e-aws-console-periodic`
ci/rehearse/devfile/integration-tests/main/v4.15.console-images	`41c1005`	link	unknown	`/pj-rehearse pull-ci-devfile-integration-tests-main-v4.15.console-images`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

* update to OpenShift 4.15 devfile integration tests Signed-off-by: Michael Valdron <mvaldron@redhat.com> * remove OpenShift 4.10 jobs Signed-off-by: Michael Valdron <mvaldron@redhat.com> * restore OpenShift 4.10 CI cron schedule for OpenShift 4.15 CI Signed-off-by: Michael Valdron <mvaldron@redhat.com> --------- Signed-off-by: Michael Valdron <mvaldron@redhat.com>

openshift-ci bot requested review from Jdubrick and thepetk June 12, 2024 19:12

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2024

This was referenced Jun 12, 2024

Update integration tests to Go 1.21 and Kubernetes 1.29 devfile/integration-tests#105

Merged

Integration tests should be updated to support Go 1.21 devfile/api#1561

Closed

openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 13, 2024

johnmcollier reviewed Jun 13, 2024

View reviewed changes

michael-valdron force-pushed the chore/devfile-tests-go-1-21 branch from 202d605 to d5cce50 Compare June 13, 2024 16:08

openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 13, 2024

johnmcollier reviewed Jun 13, 2024

View reviewed changes

michael-valdron added 3 commits June 13, 2024 14:42

update to OpenShift 4.15 devfile integration tests

7f75000

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

remove OpenShift 4.10 jobs

eec2f4e

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

restore OpenShift 4.10 CI cron schedule for OpenShift 4.15 CI

41c1005

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

michael-valdron force-pushed the chore/devfile-tests-go-1-21 branch from 54db7b9 to 41c1005 Compare June 13, 2024 18:43

michael-valdron requested a review from johnmcollier June 13, 2024 18:46

openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 13, 2024

johnmcollier approved these changes Jun 13, 2024

View reviewed changes

openshift-ci bot assigned johnmcollier Jun 13, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2024

openshift-merge-bot bot merged commit cdfda4c into openshift:master Jun 13, 2024
19 of 21 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update devfile integration tests to OpenShift 4.15 #53140

Update devfile integration tests to OpenShift 4.15 #53140

michael-valdron commented Jun 12, 2024 •

edited

Loading

michael-valdron commented Jun 12, 2024

openshift-ci-robot commented Jun 12, 2024

thepetk commented Jun 13, 2024

openshift-ci-robot commented Jun 13, 2024

thepetk commented Jun 13, 2024

openshift-ci-robot commented Jun 13, 2024

michael-valdron commented Jun 13, 2024

openshift-ci-robot commented Jun 13, 2024

johnmcollier left a comment

michael-valdron commented Jun 13, 2024

johnmcollier commented Jun 13, 2024

michael-valdron commented Jun 13, 2024

openshift-ci-robot commented Jun 13, 2024

johnmcollier left a comment

johnmcollier Jun 13, 2024

michael-valdron Jun 13, 2024

johnmcollier Jun 13, 2024

michael-valdron Jun 13, 2024

openshift-ci-robot commented Jun 13, 2024

michael-valdron commented Jun 13, 2024

openshift-ci-robot commented Jun 13, 2024

michael-valdron commented Jun 13, 2024

openshift-ci-robot commented Jun 13, 2024

johnmcollier left a comment

openshift-ci bot commented Jun 13, 2024

openshift-ci bot commented Jun 13, 2024

Update devfile integration tests to OpenShift 4.15 #53140

Update devfile integration tests to OpenShift 4.15 #53140

Conversation

michael-valdron commented Jun 12, 2024 • edited Loading

Description

michael-valdron commented Jun 12, 2024

openshift-ci-robot commented Jun 12, 2024

thepetk commented Jun 13, 2024

openshift-ci-robot commented Jun 13, 2024

thepetk commented Jun 13, 2024

openshift-ci-robot commented Jun 13, 2024

michael-valdron commented Jun 13, 2024

openshift-ci-robot commented Jun 13, 2024

johnmcollier left a comment

Choose a reason for hiding this comment

michael-valdron commented Jun 13, 2024

johnmcollier commented Jun 13, 2024

michael-valdron commented Jun 13, 2024

openshift-ci-robot commented Jun 13, 2024

johnmcollier left a comment

Choose a reason for hiding this comment

johnmcollier Jun 13, 2024

Choose a reason for hiding this comment

michael-valdron Jun 13, 2024

Choose a reason for hiding this comment

johnmcollier Jun 13, 2024

Choose a reason for hiding this comment

michael-valdron Jun 13, 2024

Choose a reason for hiding this comment

openshift-ci-robot commented Jun 13, 2024

michael-valdron commented Jun 13, 2024

openshift-ci-robot commented Jun 13, 2024

michael-valdron commented Jun 13, 2024

openshift-ci-robot commented Jun 13, 2024

johnmcollier left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Jun 13, 2024

openshift-ci bot commented Jun 13, 2024

michael-valdron commented Jun 12, 2024 •

edited

Loading