Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-7265 | feat: Added the ability to edit KubeletConfigs for HCP clusters #2036

Conversation

robpblake
Copy link
Contributor

This PR adds the ability to edit KubeletConfig for HCP clusters.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@robpblake robpblake force-pushed the ocm-7265-edit-kubeletconfig-for-hcp branch from 68a62bd to 3eccd47 Compare May 13, 2024 14:04
Copy link
Member

@ciaranRoche ciaranRoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@robpblake
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
Copy link
Contributor

openshift-ci bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciaranRoche, robpblake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ciaranRoche,robpblake]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 81.33333% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 24.94%. Comparing base (f41b67d) to head (3eccd47).
Report is 2 commits behind head on master.

Files Patch % Lines
cmd/edit/kubeletconfig/cmd.go 76.92% 9 Missing and 3 partials ⚠️
pkg/kubeletconfig/config.go 0.00% 1 Missing ⚠️
pkg/ocm/kubeletconfig.go 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2036      +/-   ##
==========================================
+ Coverage   24.71%   24.94%   +0.23%     
==========================================
  Files         145      146       +1     
  Lines       21693    21768      +75     
==========================================
+ Hits         5361     5430      +69     
- Misses      15922    15924       +2     
- Partials      410      414       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

openshift-ci bot commented May 13, 2024

@robpblake: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5b3abac into openshift:master May 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants