-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM-7265 | feat: Added the ability to edit KubeletConfigs for HCP clusters #2036
OCM-7265 | feat: Added the ability to edit KubeletConfigs for HCP clusters #2036
Conversation
68a62bd
to
3eccd47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ciaranRoche, robpblake The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2036 +/- ##
==========================================
+ Coverage 24.71% 24.94% +0.23%
==========================================
Files 145 146 +1
Lines 21693 21768 +75
==========================================
+ Hits 5361 5430 +69
- Misses 15922 15924 +2
- Partials 410 414 +4 ☔ View full report in Codecov by Sentry. |
@robpblake: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR adds the ability to edit KubeletConfig for HCP clusters.