Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest updates from master of opensim-models repo #988

Merged
merged 1 commit into from
Sep 5, 2018

Conversation

aymanhab
Copy link
Member

@aymanhab aymanhab commented Sep 5, 2018

Fixes issue #0

Brief summary of changes

Bring fixes from opensim-models repo to opensim-gui. In particular leg39 model, update StrengthOfSimulaion tutorial files for motionType

Testing I've completed

CHANGELOG.md (choose one)

  • no need to update because internal
  • updated...

@nickbianco
Copy link
Member

Cool. All these changes have been reviewed/merged in the models repo? Not sure if I need to review anything here.

@chrisdembia
Copy link
Member

I think we can merge this once the tests pass.

@aymanhab
Copy link
Member Author

aymanhab commented Sep 5, 2018

Tests passed, this can be merged or we can test the artifact from the PR build to make sure the files are properly installed so we can update before merging.

@chrisdembia
Copy link
Member

Tested locally on Mac and all looks good. Merging.

@chrisdembia chrisdembia merged commit f73ab4d into master Sep 5, 2018
@chrisdembia chrisdembia deleted the update_models_repo090518 branch September 5, 2018 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants