[コア] /file/css/1.css系のブラウザキャッシュ対応 #2142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
これにより、同じcss classがどちらにあった場合、「2.ページ毎CSS」が勝ちます。(2つに別ける前と同じ動き)
github actionsでテスト
Laravel Dusk Connect-cms-test matrix · db4ea2d
https://github.com/opensource-workshop/connect-cms/actions/runs/13889880636
→ エラーなし
修正後画面
トップページ
→ 2回目の表示以降、ブラウザキャッシュを確認(/file/css/site.css, /file/css/page/3.css)
ログイン画面
→ site.cssのブラウザキャッシュを確認(/file/css/site.css)
→ /file/css/page/1.css系は読み込んでない事を確認
管理者メニュ-画面
→ site.cssのブラウザキャッシュを確認(/file/css/site.css)
→ /file/css/page/1.css系は読み込んでない事を確認
レビュー完了希望日
なし
関連Pull requests/Issues
参考
https://www.wakuwakubank.com/posts/421-php-carbon/#index_id3
DB変更の有無
無し
チェックリスト