Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale reused geometry correctly #1322

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Conversation

muren400
Copy link
Contributor

Hi,

this commit deals with the scaling issue discussed here: #1313

This should take care of uniform and non uniform scaling.

Apply scaling from IfcCartesianTransformationOperator3D when reusing
geometry
@hlg
Copy link
Member

hlg commented Jul 23, 2024

How about Scale2 or Scale3 omitted in the non-uniform case? These attributes are optional and would probably lead to to a NullPointerException if undefined. The documentation says: " If the Scale2 or the Scale3 factor is omitted, it defaults to the value of Scale (the x axis scale factor)." Otherwise it looks good.

@muren400
Copy link
Contributor Author

muren400 commented Aug 1, 2024

I added a commit to the branch. Now it defaults to Scale if Scale2 or Scale3 are not set.

@zaqifathis
Copy link
Collaborator

I have tested the changes specifically for the non-uniform case with three mapped items using the same mapping
source and the result works as expected with no issues.

here is the test file:
three-mapped-shape-transformation-checkdefault.zip

@hlg hlg merged commit d80cce7 into opensourceBIM:master Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants