Improve a test to execute untested code in write_json_info in cobj/codegen.c #667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutaro-sakamoto
force-pushed
the
improve-coverage-info-json-dir
branch
from
e49fba2 to
f74720b
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR improves test coverage for the write_json_info functionality in cobj/codegen.c by updating the test file to execute previously untested code paths.
- Updated AT_DATA section to include a new parameter (P3) in the COBOL procedure signature.
- Updated JSON checks in the test file to verify that P3 is correctly mapped to a Java double.
kio-watanabe
approved these changes
Jun 17, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves a test in
tests/command-line-options.src/info-java-dir.at.Due to this modification, the modified test would run the following untested code. See also #662
opensourcecobol4j/cobj/codegen.c
Line 4239 in 2794a5e