Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate test bgp set aspath replace from topotests #61

Conversation

Chromico
Copy link

@Chromico Chromico commented Aug 21, 2022

Test results

root@frrr:~/newfrr1/tests/topotato# ./run_userns.sh --frr-builddir=/root/buildfrr/ --log-cli-level=DEBUG -v -v -x test_bgp_set_aspath_replace.py
========================================================================= topotato initialization =========================================================================

-------------------------------------------------------------------------- live log sessionstart --------------------------------------------------------------------------
DEBUG    topotato:topolinux.py:87 executable unshare found: /usr/bin/unshare
DEBUG    topotato:topolinux.py:87 executable nsenter found: /usr/bin/nsenter
DEBUG    topotato:topolinux.py:87 executable tini found: /usr/bin/tini
DEBUG    topotato:topolinux.py:87 executable dumpcap found: /usr/bin/dumpcap
DEBUG    topotato:topolinux.py:87 executable ip found: /usr/sbin/ip
DEBUG    topotato:frr.py:124 FRR build directory: '/root/buildfrr'
DEBUG    topotato:frr.py:139 FRR source directory: '/root/buildfrr'
INFO     topotato:frr.py:171 FRR daemons: zebra, staticd, babeld, bfdd, bgpd, eigrpd, fabricd, isisd, ldpd, nhrpd, ospf6d, ospfd, pathd, pbrd, pim6d, pimd, ripd, ripngd, vrrpd
DEBUG    topotato:frr.py:183 zebra => zebra/zebra
DEBUG    topotato:frr.py:181 ignoring target 'watchfrr/watchfrr'
DEBUG    topotato:frr.py:181 ignoring target 'tools/ssd'
DEBUG    topotato:frr.py:183 bgpd => bgpd/bgpd
DEBUG    topotato:frr.py:183 ripd => ripd/ripd
DEBUG    topotato:frr.py:183 ripngd => ripngd/ripngd
DEBUG    topotato:frr.py:183 ospfd => ospfd/ospfd
DEBUG    topotato:frr.py:183 ospf6d => ospf6d/ospf6d
DEBUG    topotato:frr.py:183 isisd => isisd/isisd
DEBUG    topotato:frr.py:183 fabricd => isisd/fabricd
DEBUG    topotato:frr.py:183 nhrpd => nhrpd/nhrpd
DEBUG    topotato:frr.py:183 ldpd => ldpd/ldpd
DEBUG    topotato:frr.py:183 babeld => babeld/babeld
DEBUG    topotato:frr.py:183 eigrpd => eigrpd/eigrpd
DEBUG    topotato:frr.py:183 pimd => pimd/pimd
DEBUG    topotato:frr.py:183 pbrd => pbrd/pbrd
DEBUG    topotato:frr.py:183 staticd => staticd/staticd
DEBUG    topotato:frr.py:183 bfdd => bfdd/bfdd
DEBUG    topotato:frr.py:183 vrrpd => vrrpd/vrrpd
DEBUG    topotato:frr.py:183 pathd => pathd/pathd
DEBUG    topotato:frr.py:181 ignoring target 'lib/grammar_sandbox'
DEBUG    topotato:frr.py:181 ignoring target 'lib/clippy'
DEBUG    topotato:frr.py:181 ignoring target 'tools/permutations'
DEBUG    topotato:frr.py:181 ignoring target 'tools/gen_northbound_callbacks'
DEBUG    topotato:frr.py:181 ignoring target 'tools/gen_yang_deviations'
DEBUG    topotato:frr.py:181 ignoring target 'bgpd/bgp_btoa'
DEBUG    topotato:frr.py:181 ignoring target 'bgpd/rfp-example/rfptest/rfptest'
DEBUG    topotato:frr.py:181 ignoring target 'ospfclient/ospfclient'
DEBUG    topotato:frr.py:181 ignoring target 'pimd/test_igmpv3_join'
DEBUG    topotato:frr.py:181 ignoring target 'pceplib/pcep_pcc'
DEBUG    topotato:pretty.py:396 executable dot found: /usr/bin/dot
Warning: daemon 'pim6d' not enabled in configure, skipping
=========================================================================== test session starts ===========================================================================
platform linux -- Python 3.8.10, pytest-6.2.4, py-1.11.0, pluggy-0.13.0 -- /usr/bin/python3
cachedir: .pytest_cache
rootdir: /root/newfrr1/tests/topotato, configfile: pytest.ini
collecting ... --------------------------------------------------------------------------- live log collection ---------------------------------------------------------------------------
DEBUG    topotato:pytestintegration.py:29 _topotato_makeitem(<Module test_bgp_set_aspath_replace.py>, 'TestBase', <class 'topotato.base.TestBase'>)
DEBUG    topotato:pytestintegration.py:29 _topotato_makeitem(<Module test_bgp_set_aspath_replace.py>, 'BGPSetAspathReplace', <class 'test_bgp_set_aspath_replace.BGPSetAspathReplace'>)
DEBUG    topotato:pytestintegration.py:29 _topotato_makeitem(<TopotatoInstance ()>, 'bgp_converge', <topotato.base.TopotatoWrapped object at 0x7efded472d90>)
DEBUG    topotato:base.py:552 collect on: <TopotatoFunction bgp_converge> test: <AssertVtysh #107:r1/bgpd/vtysh "show bgp ipv4 unicast json">
collected 3 items                                                                                                                                                         

test_bgp_set_aspath_replace.py::BGPSetAspathReplace::startup PASSED (1.51)                                                                                          [ 33%]
test_bgp_set_aspath_replace.py::BGPSetAspathReplace::bgp_converge::#107:r1/bgpd/vtysh "show bgp ipv4 unicast json" PASSED (4.59)                                    [ 66%]
test_bgp_set_aspath_replace.py::BGPSetAspathReplace::shutdown PASSED (0.44)                                                                                         [100%]

============================================================================ 3 passed in 7.02s ============================================================================
root@frrr:~/newfrr1/tests/topotato# 

patrasar and others added 30 commits March 28, 2022 05:44
Topology :-

----ens192--------+---------+
R11 -------------R2--------R3
---ens256-------+---------+

R11: receiver
R2: RP
R3: source .
There are 2 links connected between each routers .

R11: Initially (,G) joins are sent over ens192 interface
R11(config)# do show ip pim upstream 225.0.7.208
Iif Source Group State Uptime JoinTimer RSTimer KATimer RefCnt
ens192 * 225.0.7.208 J 00:00:4 00:00:30 --:--:-- --:--:-- 1

Remove PIM from interface ens192 still (*,G) iif not changed

R11(config)# interface ens192
R11(config-if)# no ip pim
R11(config-if)# exit
R11(config)# do show ip pim upstream 225.0.7.208
Iif Source Group State Uptime JoinTimer RSTimer KATimer RefCnt
ens192 * 225.0.7.208 J 00:00:12 00:00:51 --:--:-- --:--:-- 1

Fix: pim upstream rpf update taken care when pim is enabled
or disabled on an interface.

Signed-off-by: sarita patra <saritap@vmware.com>
Signed-off-by: sarita patra <saritap@vmware.com>
Signed-off-by: sarita patra <saritap@vmware.com>
Signed-off-by: sarita patra <saritap@vmware.com>
Signed-off-by: sarita patra <saritap@vmware.com>
Signed-off-by: sarita patra <saritap@vmware.com>
Signed-off-by: sarita patra <saritap@vmware.com>
Signed-off-by: sarita patra <saritap@vmware.com>
Signed-off-by: sarita patra <saritap@vmware.com>
Signed-off-by: sarita patra <saritap@vmware.com>
Fresh ground-up MLD implementation with subscriber-tracking for MLDv2.
Intended to be adapted for IPv4 and replace the IGMP implementation at a
later point.

Tested in ANVL, currently at 94/116.  Some issues/TODOs are left in the
code as CPP_NOTICE markers, but the code is very much good enough to
proceed since otherwise we're blocked on overall PIM v6 progress.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Just some basic show commands to get going.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Any interface parameters must be configurable without enabling the
protocol as a side effect; otherwise it becomes impossible to set up
things correctly without a transient misconfigured state.  Which may in
some cases break the network...

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Pending some YANG remodeling to get rid of weird time units...

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
... and add it to the daemon lists in the various tools.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
... this is not configurable yet and ANVL needs it disabled.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
... not seeing these locally, but CI is complaining.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@eqvinox
Copy link

eqvinox commented Dec 13, 2022

cherry-picked (7b06b42), closing

@eqvinox eqvinox closed this Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants