Skip to content

Moved crypto/bn/README.pod to doc/internal/man3/bn_mul_words.pod and … #26597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Moved crypto/bn/README.pod to doc/internal/man3/bn_mul_words.pod and … #26597

wants to merge 2 commits into from

Conversation

qu3ri
Copy link
Contributor

@qu3ri qu3ri commented Jan 30, 2025

…removed outdated information.

Fixes #26399

tagging @bbbrumley

Checklist
  • [x ] documentation is added or updated

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Jan 30, 2025
@richsalz
Copy link
Contributor

richsalz commented Feb 3, 2025

If you took this from QuicTLS's PR, it would be nice to give credit

@qu3ri
Copy link
Contributor Author

qu3ri commented Feb 3, 2025

I modified my commit message to credit the QuicTLS PR

@openssl-machine openssl-machine removed the hold: cla required The contributor needs to submit a license agreement label Feb 4, 2025
@bbbrumley
Copy link
Contributor

Thanks @qu3ri, this looks ready to me.

@levitte @andrewkdinh yall are subscribed to #26399, would you have a chance to review this?

Cheers thanks

@t8m t8m added branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 branch: 3.4 Merge to openssl-3.4 approval: review pending This pull request needs review by a committer triaged: documentation The issue/pr deals with documentation (errors) tests: exempted The PR is exempt from requirements for testing labels Mar 5, 2025
@t8m t8m added branch: 3.5 Merge to openssl-3.5 and removed branch: 3.1 Merge to openssl-3.1 labels Mar 19, 2025
romen
romen approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@romen romen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

@romen romen added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Mar 25, 2025
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Mar 26, 2025
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m t8m closed this Mar 26, 2025
@t8m t8m reopened this Mar 26, 2025
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Mar 26, 2025
openssl-machine pushed a commit that referenced this pull request Mar 26, 2025
@qu3ri @t8m
Moved crypto/bn/README.pod to internal manpages
6812bbc 
The new place is doc/internal/man3/bn_mul_words.pod.

Also removed outdated information.

Implementing the fix from quictls/quictls#214

Fixes #26399

Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #26597)

(cherry picked from commit 78b1fdf)
openssl-machine pushed a commit that referenced this pull request Mar 26, 2025
@qu3ri @t8m
bn_mul_words.pod: Fix failures in doc-nits check
f939936 
Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #26597)

(cherry picked from commit 1b61f8e)
openssl-machine pushed a commit that referenced this pull request Mar 26, 2025
@qu3ri @t8m
Moved crypto/bn/README.pod to internal manpages
78b1fdf 
The new place is doc/internal/man3/bn_mul_words.pod.

Also removed outdated information.

Implementing the fix from quictls/quictls#214

Fixes #26399

Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #26597)
openssl-machine pushed a commit that referenced this pull request Mar 26, 2025
@qu3ri @t8m
bn_mul_words.pod: Fix failures in doc-nits check
1b61f8e 
Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #26597)
@t8m
Copy link
Member

t8m commented Mar 26, 2025

Merged to all the active branches. Thank you for your contribution.

@t8m t8m closed this Mar 26, 2025
openssl-machine pushed a commit that referenced this pull request Mar 26, 2025
@qu3ri @t8m
Moved crypto/bn/README.pod to internal manpages
c70e8cc 
The new place is doc/internal/man3/bn_mul_words.pod.

Also removed outdated information.

Implementing the fix from quictls/quictls#214

Fixes #26399

Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #26597)

(cherry picked from commit 78b1fdf)
openssl-machine pushed a commit that referenced this pull request Mar 26, 2025
@qu3ri @t8m
bn_mul_words.pod: Fix failures in doc-nits check
ec561e8 
Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #26597)

(cherry picked from commit 1b61f8e)
openssl-machine pushed a commit that referenced this pull request Mar 26, 2025
@qu3ri @t8m
Moved crypto/bn/README.pod to internal manpages
5c86a2b 
The new place is doc/internal/man3/bn_mul_words.pod.

Also removed outdated information.

Implementing the fix from quictls/quictls#214

Fixes #26399

Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #26597)

(cherry picked from commit 78b1fdf)
openssl-machine pushed a commit that referenced this pull request Mar 26, 2025
@qu3ri @t8m
bn_mul_words.pod: Fix failures in doc-nits check
d775599 
Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #26597)

(cherry picked from commit 1b61f8e)
openssl-machine pushed a commit that referenced this pull request Mar 26, 2025
@qu3ri @t8m
Moved crypto/bn/README.pod to internal manpages
736442c 
The new place is doc/internal/man3/bn_mul_words.pod.

Also removed outdated information.

Implementing the fix from quictls/quictls#214

Fixes #26399

Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #26597)

(cherry picked from commit 78b1fdf)
openssl-machine pushed a commit that referenced this pull request Mar 26, 2025
@qu3ri @t8m
bn_mul_words.pod: Fix failures in doc-nits check
928ecb0 
Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #26597)

(cherry picked from commit 1b61f8e)
openssl-machine pushed a commit that referenced this pull request Mar 26, 2025
@qu3ri @t8m
Moved crypto/bn/README.pod to internal manpages
b2a8ad2 
The new place is doc/internal/man3/bn_mul_words.pod.

Also removed outdated information.

Implementing the fix from quictls/quictls#214

Fixes #26399

Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #26597)

(cherry picked from commit 78b1fdf)
openssl-machine pushed a commit that referenced this pull request Mar 26, 2025
@qu3ri @t8m
bn_mul_words.pod: Fix failures in doc-nits check
884b0b6 
Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #26597)

(cherry picked from commit 1b61f8e)
DDvO pushed a commit to siemens/openssl that referenced this pull request Jun 16, 2025
@qu3ri @DDvO
Moved crypto/bn/README.pod to internal manpages
b8b0edf 
The new place is doc/internal/man3/bn_mul_words.pod.

Also removed outdated information.

Implementing the fix from quictls/quictls#214

Fixes openssl#26399

Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#26597)
DDvO pushed a commit to siemens/openssl that referenced this pull request Jun 16, 2025
@qu3ri @DDvO
bn_mul_words.pod: Fix failures in doc-nits check
2106129 
Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#26597)
MichaelA-Fireblocks pushed a commit to MichaelA-Fireblocks/openssl that referenced this pull request Jul 15, 2025
@qu3ri @MichaelA-Fireblocks
Moved crypto/bn/README.pod to internal manpages
0e99a9d 
The new place is doc/internal/man3/bn_mul_words.pod.

Also removed outdated information.

Implementing the fix from quictls/quictls#214

Fixes openssl#26399

Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#26597)
MichaelA-Fireblocks pushed a commit to MichaelA-Fireblocks/openssl that referenced this pull request Jul 15, 2025
@qu3ri @MichaelA-Fireblocks
bn_mul_words.pod: Fix failures in doc-nits check
fade9d9 
Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#26597)
MichaelA-Fireblocks pushed a commit to MichaelA-Fireblocks/openssl that referenced this pull request Jul 15, 2025
@qu3ri @MichaelA-Fireblocks
Moved crypto/bn/README.pod to internal manpages
54ad28a 
The new place is doc/internal/man3/bn_mul_words.pod.

Also removed outdated information.

Implementing the fix from quictls/quictls#214

Fixes openssl#26399

Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#26597)
MichaelA-Fireblocks pushed a commit to MichaelA-Fireblocks/openssl that referenced this pull request Jul 15, 2025
@qu3ri @MichaelA-Fireblocks
bn_mul_words.pod: Fix failures in doc-nits check
6e67cee 
Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#26597)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@levitte levitte Awaiting requested review from levitte

@nhorman nhorman Awaiting requested review from nhorman

@mattcaswell mattcaswell Awaiting requested review from mattcaswell

+2 more reviewers

@romen romen romen approved these changes

@andrewkdinh andrewkdinh andrewkdinh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 branch: 3.4 Merge to openssl-3.4 branch: 3.5 Merge to openssl-3.5 severity: fips change The pull request changes FIPS provider sources tests: exempted The PR is exempt from requirements for testing triaged: documentation The issue/pr deals with documentation (errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crypto/bn/README.pod is in the wrong place
7 participants
@qu3ri @richsalz @bbbrumley @openssl-machine @t8m @romen @andrewkdinh