Skip to content

Memory leak fix ktls_meth.c #27111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Memory leak fix ktls_meth.c #27111

wants to merge 1 commit into from

Conversation

jay9827342
Copy link

@jay9827342 jay9827342 commented Mar 21, 2025 •
edited
Loading

The OSSL_RECORD_LAYER needs to be properly freed when return code isnt success. Memory leak fix
Fixes #27028

CLA: trivial

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Mar 21, 2025
@jay9827342
Copy link
Author

Signed CLA has been emailed to cla@openssl.org

@mattcaswell mattcaswell added branch: master Merge to master branch approval: review pending This pull request needs review by a committer branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 branch: 3.4 Merge to openssl-3.4 branch: 3.5 Merge to openssl-3.5 labels Mar 21, 2025
@nhorman nhorman closed this Mar 21, 2025
@nhorman nhorman reopened this Mar 21, 2025
@t8m t8m added the triaged: bug The issue/pr is/fixes a bug label Mar 21, 2025
@jay9827342 jay9827342 closed this Mar 21, 2025
@jay9827342 jay9827342 reopened this Mar 21, 2025
@t8m
Copy link
Member

t8m commented Mar 21, 2025

The e-mail address of the author must be present on the ICLA you've submitted to us. Could you please correct it either in the commit or resend a new ICLA?

Alternatively this would be acceptable with CLA: trivial.

@t8m t8m added the tests: exempted The PR is exempt from requirements for testing label Mar 21, 2025
@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Mar 21, 2025
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically,alternatively please review and set the label manually.

InfoHunter
InfoHunter approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@InfoHunter InfoHunter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed to accept this with CLA: trivial in the commit message. One previously failed test case was re-run and it's happy now. The CLA checking one is not relevant due to that the CLA trivial is accepted.

@InfoHunter InfoHunter added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Mar 25, 2025
@t8m
Copy link
Member

t8m commented Mar 25, 2025

@jay9827342 Could you please sort out the CLA problem? Either please commit this with an e-mail you've used in your CLA submission or add CLA: trivia to the commit message body.

@jay9827342
Memory leak fix ktls_meth.c
d3c41fe 
The OSSL_RECORD_LAYER needs to be properly freed when return code isnt success.
Memory leak fix

CLA: trivial
@openssl-machine openssl-machine removed the hold: cla required The contributor needs to submit a license agreement label Mar 25, 2025
openssl-machine pushed a commit that referenced this pull request Mar 25, 2025
@t8m
Memory leak fix ktls_meth.c
e5e4cf4 
The OSSL_RECORD_LAYER needs to be properly freed when return code isnt success.
Memory leak fix

CLA: trivial

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Yang <kaishen.yy@antfin.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #27111)
openssl-machine pushed a commit that referenced this pull request Mar 25, 2025
@t8m
Memory leak fix ktls_meth.c
67cc9ae 
The OSSL_RECORD_LAYER needs to be properly freed when return code isnt success.
Memory leak fix

CLA: trivial

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Yang <kaishen.yy@antfin.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #27111)

(cherry picked from commit e5e4cf4)
openssl-machine pushed a commit that referenced this pull request Mar 25, 2025
@t8m
Memory leak fix ktls_meth.c
416b515 
The OSSL_RECORD_LAYER needs to be properly freed when return code isnt success.
Memory leak fix

CLA: trivial

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Yang <kaishen.yy@antfin.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #27111)

(cherry picked from commit e5e4cf4)
openssl-machine pushed a commit that referenced this pull request Mar 25, 2025
@t8m
Memory leak fix ktls_meth.c
070856e 
The OSSL_RECORD_LAYER needs to be properly freed when return code isnt success.
Memory leak fix

CLA: trivial

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Yang <kaishen.yy@antfin.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #27111)

(cherry picked from commit e5e4cf4)
@t8m
Copy link
Member

t8m commented Mar 25, 2025

Merged to the master, 3.5, 3.4, 3.3 and 3.2 branches. Thank you for your contribution.

@t8m t8m closed this Mar 25, 2025
openssl-machine pushed a commit that referenced this pull request Mar 25, 2025
@t8m
Memory leak fix ktls_meth.c
00af1ac 
The OSSL_RECORD_LAYER needs to be properly freed when return code isnt success.
Memory leak fix

CLA: trivial

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Yang <kaishen.yy@antfin.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #27111)

(cherry picked from commit e5e4cf4)
@mattcaswell mattcaswell mentioned this pull request Apr 2, 2025
Closed
DDvO pushed a commit to siemens/openssl that referenced this pull request Jun 16, 2025
@DDvO
Memory leak fix ktls_meth.c
4919cfe 
The OSSL_RECORD_LAYER needs to be properly freed when return code isnt success.
Memory leak fix

CLA: trivial

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Yang <kaishen.yy@antfin.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#27111)
MichaelA-Fireblocks pushed a commit to MichaelA-Fireblocks/openssl that referenced this pull request Jul 15, 2025
@MichaelA-Fireblocks
Memory leak fix ktls_meth.c
c277535 
The OSSL_RECORD_LAYER needs to be properly freed when return code isnt success.
Memory leak fix

CLA: trivial

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Yang <kaishen.yy@antfin.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#27111)
MichaelA-Fireblocks pushed a commit to MichaelA-Fireblocks/openssl that referenced this pull request Jul 15, 2025
@MichaelA-Fireblocks
Memory leak fix ktls_meth.c
f7439dd 
The OSSL_RECORD_LAYER needs to be properly freed when return code isnt success.
Memory leak fix

CLA: trivial

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Yang <kaishen.yy@antfin.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#27111)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InfoHunter InfoHunter InfoHunter approved these changes

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 branch: 3.4 Merge to openssl-3.4 branch: 3.5 Merge to openssl-3.5 tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TFO causes memory leak in SSL_connect state machine
6 participants
@jay9827342 @t8m @openssl-machine @InfoHunter @mattcaswell @nhorman