Skip to content

Fix a visual glitch in test_cmp_http.t #27144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix a visual glitch in test_cmp_http.t #27144

wants to merge 2 commits into from

Conversation

bernd-edlinger
Copy link
Member

Kill the shell process after the Mock server is running, to prevent the shell from printing an error message when the Mock server is finally killed.

@bernd-edlinger
Fix a visual glitch in test_cmp_http.t
d5a2046 
Kill the shell process after the Mock server is running,
to prevent the shell from printing an error message when
the Mock server is finally killed.
@bernd-edlinger bernd-edlinger added branch: master Merge to master branch branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 branch: 3.4 Merge to openssl-3.4 branch: 3.5 Merge to openssl-3.5 labels Mar 24, 2025
paulidale
paulidale previously approved these changes Mar 24, 2025
View reviewed changes
@paulidale paulidale added the approval: review pending This pull request needs review by a committer label Mar 24, 2025
@bernd-edlinger
Copy link
Member Author

all macos-14/15 test runs show this ugly effect:

90-test_sysdefault.t .................... ok

sh: line 1: 21846 Killed: 9               ../../../../util/wrap.pl ../../../../apps/openssl cmp -config server.cnf 2> ../../../../test-runs/test_cmp_http/Mock_server_STDERR.txt80-test_cmp_http.t ...................... ok
80-test_ssl_old.t ....................... ok

that is fixed by this.

t8m
t8m previously approved these changes Mar 25, 2025
View reviewed changes
@t8m t8m added triaged: bug The issue/pr is/fixes a bug tests: present The PR has suitable tests present approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Mar 25, 2025
@bernd-edlinger bernd-edlinger mentioned this pull request Mar 25, 2025
Closed
@tmshort
Copy link
Contributor

tmshort commented Mar 25, 2025

I think the 3.0 backport code (#27158) is clearer than this code.

@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@bernd-edlinger bernd-edlinger dismissed stale reviews from t8m and paulidale via aae52b7 March 26, 2025 13:47
@bernd-edlinger
Copy link
Member Author

OK, I have updated the PR as requested. Please re-confirm.

@t8m t8m requested review from paulidale and tmshort March 26, 2025 14:46
@bernd-edlinger bernd-edlinger requested a review from DDvO March 30, 2025 08:01
DDvO
DDvO approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@DDvO DDvO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: done This pull request has the required number of approvals labels Apr 1, 2025
@openssl-machine openssl-machine removed the approval: done This pull request has the required number of approvals label Apr 2, 2025
@openssl-machine openssl-machine added the approval: ready to merge The 24 hour grace period has passed, ready to merge label Apr 2, 2025
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Apr 2, 2025
@bernd-edlinger @t8m
Fix a visual glitch in test_cmp_http.t
d5eeb8c 
Kill the shell process after the Mock server is running,
to prevent the shell from printing an error message when
the Mock server is finally killed.

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #27144)

(cherry picked from commit c45f0dd)
openssl-machine pushed a commit that referenced this pull request Apr 2, 2025
@bernd-edlinger @t8m
Fix a visual glitch in test_cmp_http.t
c45f0dd 
Kill the shell process after the Mock server is running,
to prevent the shell from printing an error message when
the Mock server is finally killed.

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #27144)
openssl-machine pushed a commit that referenced this pull request Apr 2, 2025
@bernd-edlinger @t8m
Fix a visual glitch in test_cmp_http.t
bd54eae 
Kill the shell process after the Mock server is running,
to prevent the shell from printing an error message when
the Mock server is finally killed.

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #27144)

(cherry picked from commit c45f0dd)
openssl-machine pushed a commit that referenced this pull request Apr 2, 2025
@bernd-edlinger @t8m
Fix a visual glitch in test_cmp_http.t
9df1b9d 
Kill the shell process after the Mock server is running,
to prevent the shell from printing an error message when
the Mock server is finally killed.

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #27144)

(cherry picked from commit c45f0dd)
openssl-machine pushed a commit that referenced this pull request Apr 2, 2025
@bernd-edlinger @t8m
Fix a visual glitch in test_cmp_http.t
46805ab 
Kill the shell process after the Mock server is running,
to prevent the shell from printing an error message when
the Mock server is finally killed.

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #27144)

(cherry picked from commit c45f0dd)
@t8m
Copy link
Member

t8m commented Apr 2, 2025

Merged to master, 3.5, 3.4, 3.3 and 3.2 branches. Thank you for your contribution.

@t8m t8m closed this Apr 2, 2025
@bernd-edlinger bernd-edlinger mentioned this pull request Apr 3, 2025
Closed
Sashan pushed a commit to Sashan/openssl that referenced this pull request Apr 22, 2025
@bernd-edlinger @Sashan
Fix a visual glitch in test_cmp_http.t
04ea825 
Kill the shell process after the Mock server is running,
to prevent the shell from printing an error message when
the Mock server is finally killed.

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#27144)
DDvO pushed a commit to siemens/openssl that referenced this pull request Jun 16, 2025
@bernd-edlinger @DDvO
Fix a visual glitch in test_cmp_http.t
0b81fd9 
Kill the shell process after the Mock server is running,
to prevent the shell from printing an error message when
the Mock server is finally killed.

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#27144)
MichaelA-Fireblocks pushed a commit to MichaelA-Fireblocks/openssl that referenced this pull request Jul 15, 2025
@bernd-edlinger @MichaelA-Fireblocks
Fix a visual glitch in test_cmp_http.t
ec878cc 
Kill the shell process after the Mock server is running,
to prevent the shell from printing an error message when
the Mock server is finally killed.

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#27144)
MichaelA-Fireblocks pushed a commit to MichaelA-Fireblocks/openssl that referenced this pull request Jul 15, 2025
@bernd-edlinger @MichaelA-Fireblocks
Fix a visual glitch in test_cmp_http.t
467ac3b 
Kill the shell process after the Mock server is running,
to prevent the shell from printing an error message when
the Mock server is finally killed.

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#27144)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DDvO DDvO DDvO approved these changes

@t8m t8m t8m approved these changes

@paulidale paulidale paulidale approved these changes

@tmshort tmshort Awaiting requested review from tmshort

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 branch: 3.4 Merge to openssl-3.4 branch: 3.5 Merge to openssl-3.5 tests: present The PR has suitable tests present triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bernd-edlinger @tmshort @openssl-machine @t8m @DDvO @paulidale