Fix mlx kem dup #27173
Closed
Fix mlx kem dup #27173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdukhovni
added
branch: master
vdukhovni
requested review from
t-j-h,
t8m and
mattcaswell
and removed request for
t8m
github-actions
bot
added
the
severity: fips change
vdukhovni
force-pushed
the
fix-mlx_kem_dup
branch
from
08b97ec to
22d4510
Compare
t-j-h
added
the
approval: review pending
|
@vdukhovni Could you please amend the commit message to mention the reporter? I think it is deserved. |
Issue reported by Apple Inc on 2025-03-26.
vdukhovni
force-pushed
the
fix-mlx_kem_dup
branch
from
22d4510 to
2201939
Compare
mattcaswell
approved these changes
Mar 27, 2025
|
Ok for 3.5 |
t8m
approved these changes
Mar 27, 2025
t8m
added
approval: done
paulidale
approved these changes
Mar 27, 2025
slontis
reviewed
Mar 27, 2025
| || (ret = OPENSSL_memdup(key, sizeof(*ret))) == NULL) | ||
| return NULL; | ||
|
|
||
| if (ret->propq != NULL |
There was a problem hiding this comment.
General what I would do here is set all fields that still need to be copied to NULL right after the memdup. This avoids any issues if returning early and is simple to understand. The MLX_KEY structure should also have a comment on it saying to check the mlx_kem_dup() if any fields are added.
There was a problem hiding this comment.
This is approved & ready to merge, can we do these changes in a subsequent PR?
There was a problem hiding this comment.
That's my preference, any refactoring can go in later. With a few different choices available.
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Mar 28, 2025
Issue reported by Apple Inc on 2025-03-26. Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #27173)
|
Merged to the master and 3.5 branches. Thank you. |
DDvO
pushed a commit
to siemens/openssl
that referenced
this pull request
Jun 16, 2025
Issue reported by Apple Inc on 2025-03-26. Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#27173)
MichaelA-Fireblocks
pushed a commit
to MichaelA-Fireblocks/openssl
that referenced
this pull request
Jul 15, 2025
Issue reported by Apple Inc on 2025-03-26. Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#27173)
MichaelA-Fireblocks
pushed a commit
to MichaelA-Fireblocks/openssl
that referenced
this pull request
Jul 15, 2025
Issue reported by Apple Inc on 2025-03-26. Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#27173)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trimmed to just the reported issue.