Skip to content

Fix nasm installation step #27462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix nasm installation step #27462

wants to merge 1 commit into from

Conversation

quarckster
Copy link
Contributor

@quarckster quarckster commented Apr 22, 2025 •
edited
Loading

This PR replaces ilammy/setup-nasm@v1 GitHub Actions with command to install nasm from Chocolatey software repository for Windows.

@stanciuadrian stanciuadrian mentioned this pull request Apr 22, 2025
Closed
3 tasks
@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer triaged: bug The issue/pr is/fixes a bug severity: urgent Fixes an urgent issue (exempt from 24h grace period) branch: 3.0 Merge to openssl-3.0 branch tests: present The PR has suitable tests present branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 branch: 3.4 Merge to openssl-3.4 branch: 3.5 Merge to openssl-3.5 labels Apr 22, 2025
t8m
t8m approved these changes Apr 22, 2025
View reviewed changes
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this is urgent CI fix.

mattcaswell
mattcaswell approved these changes Apr 22, 2025
View reviewed changes
Copy link
Member

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree urgent

@quarckster quarckster changed the title Fix nasm installtion step Fix nasm installation step Apr 22, 2025
@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Apr 22, 2025
openssl-machine pushed a commit that referenced this pull request Apr 22, 2025
@quarckster @t8m
Replace ilammy/setup-nasm with nasm install from choco
5c4bddd 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #27462)

(cherry picked from commit 1ad1869)
openssl-machine pushed a commit that referenced this pull request Apr 22, 2025
@quarckster @t8m
Replace ilammy/setup-nasm with nasm install from choco
5382bfc 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #27462)

(cherry picked from commit 1ad1869)
openssl-machine pushed a commit that referenced this pull request Apr 22, 2025
@quarckster @t8m
Replace ilammy/setup-nasm with nasm install from choco
1ad1869 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #27462)
openssl-machine pushed a commit that referenced this pull request Apr 22, 2025
@quarckster @t8m
Replace ilammy/setup-nasm with nasm install from choco
c4daaf9 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #27462)

(cherry picked from commit 1ad1869)
openssl-machine pushed a commit that referenced this pull request Apr 22, 2025
@quarckster @t8m
Replace ilammy/setup-nasm with nasm install from choco
6bb0ad8 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #27462)

(cherry picked from commit 1ad1869)
@t8m
Copy link
Member

t8m commented Apr 22, 2025

Merged to all the active branches. Thank you.

@t8m t8m closed this Apr 22, 2025
openssl-machine pushed a commit that referenced this pull request Apr 22, 2025
@quarckster @t8m
Replace ilammy/setup-nasm with nasm install from choco
ab2d5d2 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #27462)

(cherry picked from commit 1ad1869)
bernd-edlinger pushed a commit to bernd-edlinger/openssl that referenced this pull request Apr 22, 2025
@quarckster @bernd-edlinger
Replace ilammy/setup-nasm with nasm install from choco
9f6c0c5 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#27462)
bernd-edlinger pushed a commit to bernd-edlinger/openssl that referenced this pull request Apr 22, 2025
@quarckster @bernd-edlinger
Replace ilammy/setup-nasm with nasm install from choco
95fbc0b 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#27462)
bernd-edlinger pushed a commit to bernd-edlinger/openssl that referenced this pull request Apr 22, 2025
@quarckster @bernd-edlinger
Replace ilammy/setup-nasm with nasm install from choco
31fe369 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#27462)
bernd-edlinger pushed a commit to bernd-edlinger/openssl that referenced this pull request Apr 26, 2025
@quarckster @bernd-edlinger
Replace ilammy/setup-nasm with nasm install from choco
2de572d 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#27462)
DDvO pushed a commit to siemens/openssl that referenced this pull request Jun 16, 2025
@quarckster @DDvO
Replace ilammy/setup-nasm with nasm install from choco
1c730a1 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#27462)
MichaelA-Fireblocks pushed a commit to MichaelA-Fireblocks/openssl that referenced this pull request Jul 15, 2025
@quarckster @MichaelA-Fireblocks
Replace ilammy/setup-nasm with nasm install from choco
85b26a0 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#27462)
MichaelA-Fireblocks pushed a commit to MichaelA-Fireblocks/openssl that referenced this pull request Jul 15, 2025
@quarckster @MichaelA-Fireblocks
Replace ilammy/setup-nasm with nasm install from choco
9a98a0e 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#27462)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 branch: 3.4 Merge to openssl-3.4 branch: 3.5 Merge to openssl-3.5 severity: urgent Fixes an urgent issue (exempt from 24h grace period) tests: present The PR has suitable tests present triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quarckster @t8m @mattcaswell