CI: Remove -Wno-stringop-overflow for s390x builds #27803
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since openssl@9a78828 it should now build warning-free on s390x, so remove the '-Wno-stringop-overflow' build option for s390x builds. If newly added code causes -Wstringop-overflow warnings again, it should be noted in the CI runs and the newly added code should be fixed accordingly. Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com>
t8m
added
branch: master
t8m
approved these changes
Jun 11, 2025
|
Friendly ping :-) |
tom-cosgrove-arm
approved these changes
Jun 16, 2025
tom-cosgrove-arm
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Jun 18, 2025
Since 9a78828 it should now build warning-free on s390x, so remove the '-Wno-stringop-overflow' build option for s390x builds. If newly added code causes -Wstringop-overflow warnings again, it should be noted in the CI runs and the newly added code should be fixed accordingly. Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #27803)
|
Merged to the master branch. Thank you for your contribution. |
MichaelA-Fireblocks
pushed a commit
to MichaelA-Fireblocks/openssl
that referenced
this pull request
Jul 15, 2025
Since openssl@9a78828 it should now build warning-free on s390x, so remove the '-Wno-stringop-overflow' build option for s390x builds. If newly added code causes -Wstringop-overflow warnings again, it should be noted in the CI runs and the newly added code should be fixed accordingly. Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#27803)
MichaelA-Fireblocks
pushed a commit
to MichaelA-Fireblocks/openssl
that referenced
this pull request
Jul 15, 2025
Since openssl@9a78828 it should now build warning-free on s390x, so remove the '-Wno-stringop-overflow' build option for s390x builds. If newly added code causes -Wstringop-overflow warnings again, it should be noted in the CI runs and the newly added code should be fixed accordingly. Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#27803)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 9a78828 it should now build warning-free on s390x, so remove the '-Wno-stringop-overflow' build option for s390x builds.
If newly added code causes -Wstringop-overflow warnings again, it should be noted in the CI runs and the newly added code should be fixed accordingly.
References: #27710 (comment)