Skip to content

Conversation

t8m
Copy link
Member

@t8m t8m commented Jul 2, 2025

Checklist
  • documentation is added or updated
  • tests are added or updated

@t8m t8m added triaged: feature The issue/pr requests/adds a feature branch: 3.0 Merge to openssl-3.0 branch branch: 3.5 Merge to openssl-3.5 labels Jul 2, 2025
@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer tests: exempted The PR is exempt from requirements for testing and removed branch: 3.0 Merge to openssl-3.0 branch branch: 3.5 Merge to openssl-3.5 labels Jul 2, 2025
@t8m t8m marked this pull request as ready for review July 2, 2025 11:45
@t8m t8m added branch: 3.0 Merge to openssl-3.0 branch branch: 3.5 Merge to openssl-3.5 labels Jul 2, 2025
@t8m
Copy link
Member Author

t8m commented Jul 2, 2025

The branch 3.0 and 3.5 labels are set just for testing, not for merging it there.

@t8m
Copy link
Member Author

t8m commented Jul 2, 2025

The failure on the 3.5 branch, clearly indicates we have a problem there (#27944 fixes that).

@t8m t8m requested review from nhorman, mattcaswell and vdukhovni July 2, 2025 15:22
@paulidale
Copy link
Contributor

Nice work. It would be good if there were a way to pick up the branches automatically so this wouldn't have to be updated after each minor release. Twice a year updates aren't a huge issue, so it's not too painful.

@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jul 3, 2025
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jul 4, 2025
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m t8m removed branch: 3.0 Merge to openssl-3.0 branch branch: 3.5 Merge to openssl-3.5 labels Jul 7, 2025
@t8m
Copy link
Member Author

t8m commented Jul 7, 2025

Merged to the master branch. Thank you for the reviews.

@t8m t8m closed this Jul 7, 2025
openssl-machine pushed a commit that referenced this pull request Jul 7, 2025
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Paul Yang <paulyang.inf@gmail.com>
(Merged from #27947)
@t8m t8m mentioned this pull request Jul 7, 2025
MichaelA-Fireblocks pushed a commit to MichaelA-Fireblocks/openssl that referenced this pull request Jul 15, 2025
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Paul Yang <paulyang.inf@gmail.com>
(Merged from openssl#27947)
MichaelA-Fireblocks pushed a commit to MichaelA-Fireblocks/openssl that referenced this pull request Jul 15, 2025
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Paul Yang <paulyang.inf@gmail.com>
(Merged from openssl#27947)
Sashan pushed a commit to Sashan/openssl that referenced this pull request Jul 25, 2025
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Paul Yang <paulyang.inf@gmail.com>
(Merged from openssl#27947)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch tests: exempted The PR is exempt from requirements for testing triaged: feature The issue/pr requests/adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants