Fix perl script warnings #28046
Closed
Fix perl script warnings #28046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like some of the changes made the scripts not work; I'll be looking into it |
jogme
force-pushed
the
fix_perl_warnings
branch
2 times, most recently
from
4cd4b55 to
2613dcc
Compare
|
This workflow https://github.com/openssl/openssl/actions/runs/16315338031/job/46079802189?pr=28046 shows that the syntax error passes as awaited. After having proof for this PR, I remove the cherry pick from CI perl syntax checker PR #28024. |
Resolves: openssl/project#1273 Signed-off-by: Norbert Pocs <norbertp@openssl.org>
andrewkdinh
approved these changes
Jul 17, 2025
nhorman
approved these changes
Jul 17, 2025
Sashan
approved these changes
Jul 21, 2025
t8m
requested changes
Jul 22, 2025
t8m
added
branch: master
t8m
approved these changes
Jul 22, 2025
t8m
added
approval: done
openssl-machine
removed
the
approval: done
|
This pull request is ready to merge |
openssl-machine
added
the
approval: ready to merge
|
merged to master, thank you! |
openssl-machine
pushed a commit
that referenced
this pull request
Jul 23, 2025
Resolves: openssl/project#1273 Signed-off-by: Norbert Pocs <norbertp@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Saša Nedvědický <sashan@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #28046)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After creating a CI to check on issues in perl files (#28024), some syntax issues were uncovered. This PR addresses them.
The commit from the PR was cherry-picked to see the results of it. PLEASE keep in mind that. (outdated)Resolves: openssl/project#1273
Checklist