Skip to content

openssl rand command should use the loaded library context #28075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

openssl rand command should use the loaded library context #28075

wants to merge 1 commit into from

Conversation

danvangeest
Copy link
Contributor

Checklist

beldmit
beldmit approved these changes Jul 23, 2025
View reviewed changes
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beldmit beldmit added branch: master Merge to master branch approval: review pending This pull request needs review by a committer labels Jul 23, 2025
@danvangeest danvangeest mentioned this pull request Jul 23, 2025
Closed
2 tasks
@paulidale
Copy link
Contributor

I'd call this a bug and this could be back ported to relevant branches.

@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jul 23, 2025
t8m
t8m approved these changes Jul 24, 2025
View reviewed changes
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, a bug to be backported to all applicable branches.

@t8m t8m added triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 branch: 3.4 Merge to openssl-3.4 branch: 3.5 Merge to openssl-3.5 tests: exempted The PR is exempt from requirements for testing labels Jul 24, 2025
@t8m t8m closed this Jul 24, 2025
@t8m t8m reopened this Jul 24, 2025
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jul 24, 2025
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m t8m removed branch: 3.0 Merge to openssl-3.0 branch branch: 3.2 Merge to openssl-3.2 labels Jul 24, 2025
@t8m
Copy link
Member

t8m commented Jul 24, 2025

Merged to the master, 3.5, 3.4 and 3.3 branches. Thank you for your contribution.

@t8m t8m closed this Jul 24, 2025
openssl-machine pushed a commit that referenced this pull request Jul 24, 2025
@danvangeest @t8m
openssl rand command should use the loaded library context
e7d5398 
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #28075)
openssl-machine pushed a commit that referenced this pull request Jul 24, 2025
@danvangeest @t8m
openssl rand command should use the loaded library context
8db538e 
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #28075)

(cherry picked from commit e7d5398)
openssl-machine pushed a commit that referenced this pull request Jul 24, 2025
@danvangeest @t8m
openssl rand command should use the loaded library context
67feeb1 
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #28075)

(cherry picked from commit e7d5398)
openssl-machine pushed a commit that referenced this pull request Jul 24, 2025
@danvangeest @t8m
openssl rand command should use the loaded library context
64457c5 
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #28075)

(cherry picked from commit e7d5398)
@danvangeest danvangeest deleted the dvg/rand_uses_libctx branch August 11, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@beldmit beldmit beldmit approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.3 Merge to openssl-3.3 branch: 3.4 Merge to openssl-3.4 branch: 3.5 Merge to openssl-3.5 tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danvangeest @paulidale @openssl-machine @t8m @beldmit