coverity fixes for apps/s_server.c #28101
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We assign an allocated pointer to *sk_resp but only check if sk_resp is NULL when sk_resp is a pointer to a pointer Addresses https://scan5.scan.coverity.com/#/project-view/60762/10222?selectedIssue=1659227
Its possible for get_ocsp_resp_from_responder to return OK after having freed *sk_resp without setting the freed pointer to NULL, leading us to set a garbage pointer in other code. Ensure that we set it to NULL after freeing Addresses https://scan5.scan.coverity.com/#/project-view/60762/10222?selectedIssue=1659225
We assign an allocation to *sk_resp, but only check for NULL on sk_resp, not the value it points to. Addresses https://scan5.scan.coverity.com/#/project-view/60762/10222?selectedIssue=1659222
nhorman
added
branch: master
paulidale
approved these changes
Jul 27, 2025
DDvO
approved these changes
Jul 28, 2025
github-project-automation
bot
moved this from Waiting Review
to Waiting Merge
in Development Board
DDvO
added
approval: done
2 tasks
vdukhovni
approved these changes
Jul 28, 2025
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
merged to master, thank you |
github-project-automation
bot
moved this from Waiting Merge
to Done
in Development Board
openssl-machine
pushed a commit
that referenced
this pull request
Jul 29, 2025
We assign an allocated pointer to *sk_resp but only check if sk_resp is NULL when sk_resp is a pointer to a pointer Addresses https://scan5.scan.coverity.com/#/project-view/60762/10222?selectedIssue=1659227 Reviewed-by: Viktor Dukhovni <viktor@openssl.org> Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com> Reviewed-by: Paul Dale <ppzgs1@gmail.com> (Merged from #28101)
openssl-machine
pushed a commit
that referenced
this pull request
Jul 29, 2025
Its possible for get_ocsp_resp_from_responder to return OK after having freed *sk_resp without setting the freed pointer to NULL, leading us to set a garbage pointer in other code. Ensure that we set it to NULL after freeing Addresses https://scan5.scan.coverity.com/#/project-view/60762/10222?selectedIssue=1659225 Reviewed-by: Viktor Dukhovni <viktor@openssl.org> Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com> Reviewed-by: Paul Dale <ppzgs1@gmail.com> (Merged from #28101)
openssl-machine
pushed a commit
that referenced
this pull request
Jul 29, 2025
We assign an allocation to *sk_resp, but only check for NULL on sk_resp, not the value it points to. Addresses https://scan5.scan.coverity.com/#/project-view/60762/10222?selectedIssue=1659222 Reviewed-by: Viktor Dukhovni <viktor@openssl.org> Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com> Reviewed-by: Paul Dale <ppzgs1@gmail.com> (Merged from #28101)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few coverity reports came in over the weekend, this PR addresses:
https://scan5.scan.coverity.com/#/project-view/60762/10222?selectedIssue=1659227
https://scan5.scan.coverity.com/#/project-view/60762/10222?selectedIssue=1659225
https://scan5.scan.coverity.com/#/project-view/60762/10222?selectedIssue=1659222
All amount to improper NULL checks in various recently modified locations in s_server.c