Ignore generated assembler files for cpuid functions #28318
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The architecture-specific code to detect CPU features at runtime is generated from Perl Assembler. Modify the ignore pattern to match the generated .S files for all architectures. Signed-off-by: Holger Dengler <dengler@linux.ibm.com>
paulidale
approved these changes
Aug 21, 2025
paulidale
added
branch: master
|
Any suggestion as to which branches this should go to? |
|
In my opinion, it should be sufficient to add this to master only. |
t8m
approved these changes
Aug 21, 2025
t8m
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
Merged to |
openssl-machine
pushed a commit
that referenced
this pull request
Aug 22, 2025
The architecture-specific code to detect CPU features at runtime is generated from Perl Assembler. Modify the ignore pattern to match the generated .S files for all architectures. Signed-off-by: Holger Dengler <dengler@linux.ibm.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Todd Short <todd.short@me.com> (Merged from #28318)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The architecture-specific code to detect CPU features at runtime is generated from Perl Assembler. Modify the ignore pattern to match the generated .S files for all architectures.
Checklist