Skip to content

3.6 Add OSSL_ prefix back onto param names #28544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

3.6 Add OSSL_ prefix back onto param names #28544

wants to merge 1 commit into from

Conversation

paulidale
Copy link
Contributor

As #28529 for 3.6

@paulidale paulidale self-assigned this Sep 14, 2025
@paulidale paulidale added triaged: refactor The issue/pr requests/implements refactoring tests: exempted The PR is exempt from requirements for testing style: waived exempted from style checks branch: 3.6 Merge to openssl-3.6 labels Sep 14, 2025
@paulidale paulidale changed the base branch from master to openssl-3.6 September 14, 2025 23:47
@paulidale paulidale requested review from beldmit, mattcaswell and t8m and removed request for mattcaswell September 14, 2025 23:48
@paulidale paulidale mentioned this pull request Sep 14, 2025
Closed
@beldmit
Copy link
Member

beldmit commented Sep 15, 2025

Why was only one test run?

beldmit
beldmit approved these changes Sep 15, 2025
View reviewed changes
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it looks like smth is wrong with tests

@mattcaswell mattcaswell reopened this Sep 15, 2025
@mattcaswell
Copy link
Member

Why was only one test run?

No idea. But I closed/reopened and they seem to be running now.

@mattcaswell mattcaswell added the approval: done This pull request has the required number of approvals label Sep 15, 2025
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Sep 15, 2025
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Sep 16, 2025
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@paulidale
Copy link
Contributor Author

Merged to 3.6, thanks for the reviews.

@paulidale paulidale closed this Sep 16, 2025
@paulidale paulidale deleted the re-ossl-3.6 branch September 16, 2025 22:50
openssl-machine pushed a commit that referenced this pull request Sep 16, 2025
@paulidale
Add OSSL_ prefix back onto param names
106bb67 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
(Merged from #28544)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattcaswell mattcaswell mattcaswell approved these changes

@beldmit beldmit beldmit approved these changes

@t8m t8m Awaiting requested review from t8m

Assignees

@paulidale paulidale

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: 3.6 Merge to openssl-3.6 severity: fips change The pull request changes FIPS provider sources style: waived exempted from style checks tests: exempted The PR is exempt from requirements for testing triaged: refactor The issue/pr requests/implements refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@paulidale @beldmit @mattcaswell @openssl-machine