ts_conf: fix memory leak in TS_CONF_set_policies #28686
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openssl-machine
added
the
hold: cla required
bleeqer
force-pushed
the
fix-ts-conf-policies-leak
branch
from
3c6358f to
b5b7f92
Compare
|
I’ve signed the CLA with this email (bleeqtheproducer@gmail.com). Please re-run the check. |
paulidale
approved these changes
Sep 29, 2025
openssl-machine
removed
the
hold: cla required
t8m
approved these changes
Sep 29, 2025
t8m
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Oct 1, 2025
Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #28686)
|
Merged to all the active branches. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TS_CONF_set_policies() allocated ASN1_OBJECTs via OBJ_txt2obj()
but did not free them after calling TS_RESP_CTX_add_policy().
Since TS_RESP_CTX_add_policy() duplicates the object internally,
the temporary ASN1_OBJECT must always be freed.
This patch ensures ASN1_OBJECT_free() is called on both success
and failure paths, preventing a per-policy memory leak.
Fixes #28628