Fix broken "openssl genrsa" and other misc option issues #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…empt to load engine with name of out.key. e.g. without fix, operation succeeds but with warnings: $ apps/openssl genrsa -out out.key invalid engine "out.key" 140735214080848:error:25066067:DSO support routines:DLFCN_LOAD:could not load the shared library:dso_dlfcn.c:172:filename(/usr/local/ssl/lib/engines/libout.key.dylib): dlopen(/usr/local/ssl/lib/engines/libout.key.dylib, 2): image not found 140735214080848:error:25070067:DSO support routines:DSO_load:could not load the shared library:dso_lib.c:228: 140735214080848:error:260B6084:engine routines:DYNAMIC_LOAD:dso not found:eng_dyn.c:458: 140735214080848:error:2606A074:engine routines:ENGINE_by_id:no such engine:eng_list.c:379:id=out.key 140735214080848:error:25066067:DSO support routines:DLFCN_LOAD:could not load the shared library:dso_dlfcn.c:172:filename(libout.key.dylib): dlopen(libout.key.dylib, 2): image not found 140735214080848:error:25070067:DSO support routines:DSO_load:could not load the shared library:dso_lib.c:228: 140735214080848:error:260B6084:engine routines:DYNAMIC_LOAD:dso not found:eng_dyn.c:458: Generating RSA private key, 2048 bit long modulus .............+++ .............................................................................................................+++ e is 65537 (0x010001) A quick grep for "=" on a line before "case" found two other similar issues addressed in same commit.
aeijdenberg
force-pushed
the
fixgenrsabug
branch
from
2af0116
to
36f4de1
Compare
|
fixed thanks! |
mcr
pushed a commit
to mcr/openssl
that referenced
this pull request
Jun 22, 2021
…algorithm ts: simplify OpenSSL::Timestamp::Request#algorithm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
genrsa is missing a break; statement after capturing the out file argument and as such many spurious warnings about missing engines are displayed (at least on Mac OS X systems, I didn't see these warnings on Linux earlier today).
A quick grep revealed 2 other similar issues.