[OSPRH-12359] Fix getting IPSets #574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vyzigold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Turns out IPSets use the node's hostname as defined in the nodeset CR, not the node's name. These 2 might be the same, but they might differ and in case they differ, the controller doesn't find them and it uses the ansible inventory secret to get the IPs instead. Unfortunatelly the hostname from the nodeset isn't always copied into the ansible inventory secret. It either gets copied into the canonical_hostname variable as is or a DNS domain is appended to it, so I introduced a bit of code to pick the correct parts of the canonical_hostname. This worked for both cases described above when I tested it, there is also still the fallback to using the ansibleHost from the inventory secret.
|
/retest |
5 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/lgtm |
openshift-merge-bot
bot
merged commit 23ac41a
into
openstack-k8s-operators:main
6 checks passed
|
/cherry-pick 18.0-fr1 |
|
@vyzigold: new pull request created: #590 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out IPSets use the node's hostname as defined in the nodeset CR, not the node's name. These 2 might be the same, but they might differ and in case they differ, the controller doesn't find them and it uses the ansible inventory secret to get the IPs instead.
Unfortunatelly the hostname from the nodeset isn't always copied into the ansible inventory secret. It either gets copied into the canonical_hostname variable as is or a DNS domain is appended to it, so I introduced a bit of code to pick the correct parts of the canonical_hostname.
This worked for both cases described above when I tested it, there is also still the fallback to using the ansibleHost from the inventory secret.