Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presets: update Costco, Sam's Club to shop=warehouse #4657

Closed
wants to merge 1 commit into from
Closed

Presets: update Costco, Sam's Club to shop=warehouse #4657

wants to merge 1 commit into from

Conversation

HubMiner
Copy link

@HubMiner HubMiner commented Jan 5, 2018

No description provided.

@bhousel
Copy link
Member

bhousel commented Jan 5, 2018

Thanks for the PR, but this change needs to be made in the name-suggestion-index project. That is iD's source for the presets for chain stores.

I'd also drop the building and access tags for these. access=customers is implied, or more for parking lots. building really depends on whether a mapper wants to map it as a building or not (and I'd consider it more building=retail than building=commercial anyway).

@bhousel bhousel closed this Jan 5, 2018
@1ec5
Copy link
Collaborator

1ec5 commented Jan 5, 2018

By the way, shop=warehouse appears to be little used at this point. Most Costco and Sam’s Club locations have been mapped as shop=wholesale or shop=department_store. (This PR uses shop=wholesale, but the title and commit message are a bit misleading.)

@HubMiner
Copy link
Author

HubMiner commented Jan 5, 2018

shop=warehouse : good catch, typo in subject.

@HubMiner
Copy link
Author

HubMiner commented Jan 5, 2018

I was hoping to keep building=retail, to normalize future values, but I will defer to my seniors... :)

Another topic, I am proposing to update name:

  1. Correct name is "Costco Wholesale",
  2. Any objections?

@HubMiner HubMiner deleted the presets-costco branch January 18, 2018 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants