-
Notifications
You must be signed in to change notification settings - Fork 2
chore(cmdline): Adds nano plaintext to cmdline #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @dmihalcik-virtru, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've added a new command-line option to the createNanoTDF
command, allowing users to specify how the policy is embedded within the NanoTDF, either as plaintext or encrypted. This enhancement provides more control over the policy's visibility directly from the command line.
Highlights
- New
policy-type
option: Introduced a--policy-type
command-line option for thecreateNanoTDF
command, enabling users to choose betweenplaintext
andencrypted
policy embedding. - Policy handling logic: Implemented logic to process the
--policy-type
argument, mappingplaintext
toEMBEDDED_POLICY_PLAIN_TEXT
andencrypted
(or default) toEMBEDDED_POLICY_ENCRYPTED
.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a --policy-type
command-line option to the encryptnano
command, allowing users to specify whether the policy in a NanoTDF should be embedded as plaintext or encrypted. My review includes a suggestion to improve the robustness and readability of the new option handling logic by making it case-insensitive and using a more modern Java construct.
blocked by opentdf/tests#330 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a sanity check test case somewhere here
java-sdk/.github/workflows/checks.yaml
Lines 242 to 261 in 47041c5
echo "rs256 assertions" | |
java -jar target/cmdline.jar \ | |
--client-id=opentdf-sdk \ | |
--client-secret=secret \ | |
--platform-endpoint=http://localhost:8080 \ | |
-h\ | |
encrypt --kas-url=http://localhost:8080 --mime-type=text/plain --with-assertions "$SIGNED_ASSERTIONS_RS256" --autoconfigure=false -f data -m 'here is some metadata' > test.tdf | |
java -jar target/cmdline.jar \ | |
--client-id=opentdf-sdk \ | |
--client-secret=secret \ | |
--platform-endpoint=http://localhost:8080 \ | |
-h\ | |
decrypt --with-assertion-verification-keys "$SIGNED_ASSERTION_VERIFICATON_RS256" -f test.tdf > decrypted | |
if ! diff -q data decrypted; then | |
printf 'decrypted data is incorrect [%s]' "$(< decrypted)" | |
exit 1 | |
fi |
|
No description provided.