Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCE: Setting Container Engine on Node #2141

Closed
dampsoft-david opened this issue Apr 11, 2023 · 8 comments · Fixed by #2153
Closed

CCE: Setting Container Engine on Node #2141

dampsoft-david opened this issue Apr 11, 2023 · 8 comments · Fixed by #2153
Assignees
@vladimirvshivkov
Labels
enhancement

Comments

@dampsoft-david
Copy link

dampsoft-david commented Apr 11, 2023 •
edited

Description of the enhancement

Hey,
with release of Kubernetes 1.25 for CCE we wanted to Create a new Cluster with containerd as Container Engine, but we couldn't find the argument.
Can we get the Argument for CCE Nodes to set the Container Engine to docker/containerd?

Greetings
@vladimirvshivkov vladimirvshivkov self-assigned this Apr 12, 2023
@vladimirvshivkov vladimirvshivkov mentioned this issue Apr 20, 2023
Merged
5 tasks
otc-zuul bot pushed a commit that referenced this issue Apr 20, 2023
@vladimirvshivkov
[CCE] Add runtime container option (#2146)
69cac08 
[CCE] Add runtime container option

Summary of the Pull Request
PR Checklist

 Refers to: #2141
 Tests added/passed.
 Documentation updated.
 Schema updated.
 Release notes added.

Acceptance Steps Performed
=== RUN   TestAccCCENodesV3Basic
--- PASS: TestAccCCENodesV3Basic (181.11s)

PASS

=== RUN   TestAccCCENodesV3DataSource_basic
--- PASS:  TestAccCCENodesV3DataSource_basic (4.70s)

PASS

=== RUN   TestAccCCENodePoolsV3_basic
--- PASS: TestAccCCENodePoolsV3_basic (200.10s)

PASS

Process finished with exit code 0

Reviewed-by: Artem Lifshits
@vladimirvshivkov
Copy link
Contributor

Released in latest v1.34.2.

@john-funk
Copy link

Is there an option to avoid replacing nodes? Both the default "docker" as well as "containerd" value force a replacement of the node which is rather unfortunate for production environments.

@vladimirvshivkov
Copy link
Contributor

@Jay-Funk
If runtime is the same with node, no replacement will happen.
Otherwise, node or nodepool will be recreated.

@john-funk
Copy link

Where can I see the current runtime?

I have a node that was created with v1.34.1 so that I was not able to change the runtime value.
But both using the default "docker" runtime as well as using "containerd" replaces the node.

@vladimirvshivkov
Copy link
Contributor

that's basically docker everythere.
then try to import the node or nodepool like this:
terraform import opentelekomcloud_cce_node_pool_v3.pool_1 14a80bc7-c12c-4fe0-a38a-cb77eeac9bd6/89c60255-9bd6-460c-822a-e2b959ede9d2

@john-funk
Copy link

So it's not possible to use the newer version without having to reimport all nodes manually?

@vladimirvshivkov
Copy link
Contributor

It's possible, but if runtime value is not equal, node will be recreated.
If the ForceNew parameter is not set, then users may face an issue where, for example, runtime of node is docker, but you set containerd, users will get an error and no node will be created, and all infrastructure will not be updated.
that's the bigger issue, I guess.

Have to think about fix for that case. And will release it soon as a hotfix.

@vladimirvshivkov vladimirvshivkov mentioned this issue Apr 28, 2023
Merged
3 tasks
otc-zuul bot pushed a commit that referenced this issue May 2, 2023
@vladimirvshivkov
[CCE] runtime force replacement fix (#2153)
29b610c 
[CCE] runtime force replacement fix

Summary of the Pull Request
Fix for backward compatibility of runtime option, removed forcenew.
This issue is impossible to check in acceptance tests because we need 2 versions of provider.
Tests were run in the local environment.
PR Checklist

 Refers to: #2141
 Documentation updated.
 Release notes added.

Reviewed-by: Aloento
Reviewed-by: Anton Sidelnikov
Reviewed-by: Vladimir Vshivkov
Reviewed-by: Artem Lifshits
@vladimirvshivkov
Copy link
Contributor

Fix released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vladimirvshivkov vladimirvshivkov

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CCE] runtime force replacement fix opentelekomcloud/terraform-provider-opentelekomcloud
3 participants
@vladimirvshivkov @dampsoft-david @john-funk