do not attempt to reconnect if there are open subscriptions #200
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
run-bittensor-sdk-tests
basfroman
approved these changes
Oct 8, 2025
thewhaleking
deleted the
fix/thewhaleking/ensure-reconnections-do-not-happen-with-open-subscriptions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that we do not attempt to reconnect if there are open subscriptions.
While it is technically possible for us to reconnect and resubmit the subscription, there is a very real likelihood that the user will have missed something in between the last-received subscription update and the one after we reconnect. It is better, therefore, to just raise the exception, and allow the user to handle this error (probably by running some sort of catchup for the time that was missed, and then re-subscribing).