Skip to content

Conversation

gztensor
Copy link
Contributor

@gztensor gztensor commented Feb 7, 2025

Description

Remove DefaultMaxTempo, MaxTempo, AvgTempo, and outdated comments about min stake

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe): Cleanup

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gztensor gztensor requested a review from unconst as a code owner February 7, 2025 15:59
@github-actions github-actions bot added the hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet label Feb 7, 2025
@gztensor gztensor changed the base branch from main to devnet-ready February 7, 2025 15:59
@gztensor gztensor removed the hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet label Feb 7, 2025
@opentensor opentensor deleted a comment from github-actions bot Feb 7, 2025
camfairchild
camfairchild previously approved these changes Feb 7, 2025
@gztensor gztensor added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Feb 7, 2025
@sam0x17 sam0x17 removed the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Feb 7, 2025
@camfairchild camfairchild added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Feb 7, 2025
camfairchild
camfairchild previously approved these changes Feb 7, 2025
@sam0x17 sam0x17 dismissed camfairchild’s stale review February 13, 2025 22:16

The merge-base changed after approval.

@sam0x17 sam0x17 merged commit 7bcb158 into devnet-ready Feb 18, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants