Skip to content

Feat/dont let coldkey in swap add stake #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 12, 2025
Merged

Feat/dont let coldkey in swap add stake #1282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e538804
dont let ck-in-swap-sched move any stake/register
camfairchild Feb 12, 2025
8f197a2
add tests for validation filter
camfairchild Feb 12, 2025
5b3d4e6
add transfer stake to call nontransfer proxy filter
camfairchild Feb 12, 2025
45a67fc
also add proxy filters for new calls
camfairchild Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions pallets/subtensor/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1885,6 +1885,12 @@ where
netuid,
amount_staked,
}) => {
if ColdkeySwapScheduled::<T>::contains_key(who) {
return InvalidTransaction::Custom(
CustomTransactionError::ColdkeyInSwapSchedule.into(),
)
.into();
}
// Fully validate the user input
Self::result_to_validity(Pallet::<T>::validate_add_stake(
who,
Expand All @@ -1902,6 +1908,13 @@ where
limit_price,
allow_partial,
}) => {
if ColdkeySwapScheduled::<T>::contains_key(who) {
return InvalidTransaction::Custom(
CustomTransactionError::ColdkeyInSwapSchedule.into(),
)
.into();
}

// Calcaulate the maximum amount that can be executed with price limit
let max_amount = Pallet::<T>::get_max_amount_add(*netuid, *limit_price);

Expand Down Expand Up @@ -1957,6 +1970,13 @@ where
destination_netuid,
alpha_amount,
}) => {
if ColdkeySwapScheduled::<T>::contains_key(who) {
return InvalidTransaction::Custom(
CustomTransactionError::ColdkeyInSwapSchedule.into(),
)
.into();
}

// Fully validate the user input
Self::result_to_validity(Pallet::<T>::validate_stake_transition(
who,
Expand All @@ -1978,6 +1998,13 @@ where
destination_netuid,
alpha_amount,
}) => {
if ColdkeySwapScheduled::<T>::contains_key(who) {
return InvalidTransaction::Custom(
CustomTransactionError::ColdkeyInSwapSchedule.into(),
)
.into();
}

// Fully validate the user input
Self::result_to_validity(Pallet::<T>::validate_stake_transition(
who,
Expand All @@ -1998,6 +2025,13 @@ where
destination_netuid,
alpha_amount,
}) => {
if ColdkeySwapScheduled::<T>::contains_key(who) {
return InvalidTransaction::Custom(
CustomTransactionError::ColdkeyInSwapSchedule.into(),
)
.into();
}

// Fully validate the user input
Self::result_to_validity(Pallet::<T>::validate_stake_transition(
who,
Expand All @@ -2020,6 +2054,13 @@ where
limit_price,
allow_partial,
}) => {
if ColdkeySwapScheduled::<T>::contains_key(who) {
return InvalidTransaction::Custom(
CustomTransactionError::ColdkeyInSwapSchedule.into(),
)
.into();
}

// Get the max amount possible to exchange
let max_amount = Pallet::<T>::get_max_amount_move(
*origin_netuid,
Expand All @@ -2042,6 +2083,13 @@ where
))
}
Some(Call::register { netuid, .. } | Call::burned_register { netuid, .. }) => {
if ColdkeySwapScheduled::<T>::contains_key(who) {
return InvalidTransaction::Custom(
CustomTransactionError::ColdkeyInSwapSchedule.into(),
)
.into();
}

let registrations_this_interval =
Pallet::<T>::get_registrations_this_interval(*netuid);
let max_registrations_per_interval =
Expand Down
Loading
Loading