Fix/weights mismatch #2049
Merged
Fix/weights mismatch #2049
+1,586
−515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0r1s
added
skip-cargo-audit
l0r1s
requested review from
sam0x17,
shamil-gadelshin,
JohnReedV,
open-junius,
gztensor and
ales-otf
l0r1s
commented
Sep 16, 2025
Comment on lines
+608
to
+612
| let pays = if dispatch_infos.clone().any(|di| di.pays_fee == Pays::No) { | ||
| Pays::No | ||
| } else { | ||
| Pays::Yes | ||
| }; |
There was a problem hiding this comment.
This part matters to have Pays::No propagated
l0r1s
commented
Sep 16, 2025
| // AccountData for inner call origin accountdata. | ||
| .saturating_add(T::DbWeight::get().reads_writes(1, 1)) | ||
| .saturating_add(di.call_weight), | ||
| di.class, di.pays_fee) |
There was a problem hiding this comment.
Here we use the pays_fee from the inner call, that way if it's Pays::No, this is propagated to the proxy call
sam0x17
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the weights mismatch from pre/post DispatchInfo in the logs.
Utility/Proxy pallets are upgraded.
Issue with non accounted weight is fixed while still allowing Pays::No call to passthrough (here and here)
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.