Skip to content

Conversation

orriin
Copy link
Contributor

@orriin orriin commented Sep 20, 2024

Closes #816

Tiny rounding errors occur during runtime operation due to floating point arithmetic. Allow up to 1k RAO (fractions of fractions of a cent) delta in expected and actual TI before failing the try-state invariant.

@orriin orriin requested a review from unconst as a code owner September 20, 2024 10:08
@orriin orriin added the no-spec-version-bump PR does not contain changes that requires bumping the spec version label Sep 20, 2024
@orriin orriin force-pushed the allow-tiny-ti-delta branch 2 times, most recently from f6c0902 to c2f6476 Compare September 20, 2024 10:20
@orriin orriin force-pushed the allow-tiny-ti-delta branch from c2f6476 to 3a02677 Compare September 20, 2024 10:25
Copy link
Contributor

@sam0x17 sam0x17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this is fine, but ofc I would prefer the removal of all floating point ops in the runtime ;)

@unconst unconst merged commit 9385f06 into devnet-ready Sep 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-spec-version-bump PR does not contain changes that requires bumping the spec version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants