This repository has been archived by the owner on May 20, 2023. It is now read-only.
[Enhancement] - Added boolean value to enable or disable greeting, ungreeting and trade npc callback #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to control which npcs will have, by default, the greet, ungreet and trade callbacks enabled, if false, the npc will not use the callback and will need to use something custom Added to disable trade callback on "Yana, Peter and Sandomo" npcs Can also be applied to use alternatives to hi or bye
dudantas
changed the title
dudantas
changed the title
majestyotbr
approved these changes
Aug 5, 2022
8 tasks
guispiller
approved these changes
Aug 12, 2022
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to control which npcs will have, by default, the greet, ungreet and trade callbacks enabled, if false, the npc will not use the callback and will need to use something custom
If no parameter (true or false) is provided in the npc NpcHandler:addModule, it will inform the distro with a warning and set the default to true
Added to disable trade callback on "Yana, Peter and Sandomo" npcs (and allow the possibility of modifying in other npcs if necessary)