-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Fix general StyleCop errors #793
Merged
Nihlus
merged 28 commits into
opentk:4.0
from
FreezyLemon:4.0-fix-general-stylecop-errors
Jul 31, 2018
Merged
[4.0] Fix general StyleCop errors #793
Nihlus
merged 28 commits into
opentk:4.0
from
FreezyLemon:4.0-fix-general-stylecop-errors
Jul 31, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Single-line comments should be preceded but not be followed by a blank line.
…parameter should be placed on its own line.
<see cref="MyClass" /> turns into <see cref="MyClass"/>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
After getting the CI scripts to work again, it would be nice to actually use them, so I removed a bit more than half of the initial stylecop errors (down to ~2000), most of which were just done via automatic commands (Intellisense quick actions).
Only OpenTK.Mathematics and .OpenAL have style errors left now, the math library having a lot of documentation issues (missing punctuation, missing docs in general).
Both of those will need more work, but this PR is complete for now.