Fix empty connection data parameter #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @maikthomas for this PR. Could you please add a unit test for it to prevent regressions? |
|
@marcioaffonso I've add the fix and a unit test to check it. |
|
@marcioaffonso all tests now pass, thanks to @aiham 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate token: I have made it so that the
connection_dataparameter of a token is not sent if empty (None, "" or whatever). This is in keeping with the behaviour of the other opentok SDKs.This also avoids a bug where
connection_dataof valueNoneis converted to string"None". https://github.com/kennethreitz/requests/issues/378I have also simplified the check for empty data to
if data: