Add SIP Outbound video Flag and PlayDTMF function with API endpoints #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calthoff
reviewed
Jul 28, 2021
Hi Cory! Ok, sounds good! Force Mute allows a moderator to force clients to mute their audio in streams they publish. So I can add something like that to elaborate on it. |
calthoff
reviewed
Jul 28, 2021
| will join | ||
|
|
||
| :param connection_id An optional parameter used to send the DTMF tones to a specific | ||
| connectoiin in a session. |
calthoff
reviewed
Jul 28, 2021
| @@ -1042,6 +1050,7 @@ def dial(self, session_id, token, sip_uri, options=[]): | |||
| """ | |||
| payload = {"sessionId": session_id, "token": token, "sip": {"uri": sip_uri}} | |||
| observeForceMute = False | |||
There was a problem hiding this comment.
Why define observeForceMute and video flags? They don't seem to get used.
calthoff
reviewed
Jul 28, 2021
| @@ -1447,3 +1460,41 @@ def mute(self, session_id: str, stream_id: str= "", options: dict = {}) -> reque | |||
| ("There was an error thrown by the OpenTok SDK, please check that your session_id {0} and stream_id (if exists) {1} are valid").format( | |||
| session_id, stream_id)) | |||
|
|
|||
| def play_dtmf(self, session_id: str, connection_id: str, digits: str, options: dict = {}) -> requests.Response: | |||
| """ | |||
| Plays a DTMF string into a session or to a specific connection | |||
There was a problem hiding this comment.
As someone new to this, I'm not clear what a DTMF string is or what it means to play a DTMF string.
calthoff
reviewed
Jul 28, 2021
| try: | ||
| if not connection_id: | ||
| url = self.endpoints.get_dtmf_all_url(session_id) | ||
| payload = {"digits": digits} |
There was a problem hiding this comment.
Why define payload twice if it is the same in either case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
These changes are for the following JIRA tickets:
Add SIP Video Outbound flag to Python sDK: https://jira.vonage.com/browse/DEVX-5646
Add "Play DTMF" API to Python SDK: https://jira.vonage.com/browse/DEVX-5652