CMake: changes needed to build on Linux #452
Conversation
| set(TIFF_LIB ${TIFF_LIBRARY}) | ||
| # the libraries have not .pc nor preferred Find*.cmake. use custom modules. | ||
| # find_package(PNG REQUIRED) | ||
| set(PNG_LIB ${SDKROOT}/libpng-1.6.21/.libs/libpng16.so) |
There was a problem hiding this comment.
Many distros ship current versions of libpng, can this be changed into a fallback only when system libpng is not found?
There was a problem hiding this comment.
If anything, there should be a static switch for using system libpng IMO. Autodetecting stuff like that and building a software differently based on the result is bad for packaging that software reproducibly (i.e. the packaging process will result in different packages depending on whether libpng is installed on the build system or not. So if some package maintainer is unaware of the autodetection he might create a package without the libpng dependency and someone with system libpng available will end up with a package with incomplete dependency information).
There was a problem hiding this comment.
Updated it to use systems libpng.
@J5lx, CMake lists libraries used, package maintainers can pass them explicitly to CMake if they don't want to use auto-detection. (CMake is often used this way)
There was a problem hiding this comment.
Even so I believe it's better to be explicit about dependencies. But I guess it's a somewhat controversial topic after all (though far less controversial than code style or editors 😉) so let's not make mountains out of molehills. I'll just try to find that list of libraries in the future.
There was a problem hiding this comment.
Being explicit about dependencies within the CMake files can make bisecting older versions of the software difficult. (unless your project keeps an image of the platform used to build each version - some do).
In my experience its best to store exact configurations in a separate CMake configuration file or build script.
Note that these are the main changes from the linux port. Not a fully working linux port.
|
Jenkins, test this. |
|
LGTM |
Note that these are the main changes from the linux port.
Not a fully working linux port.
Merging this will make updating from master less hassle.