This repository has been archived by the owner on May 23, 2023. It is now read-only.
Support ForeachBaggageItem #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assertEqual(t, "my-awesome-library", rawSpan.Tags["component"]) | ||
| assertEqual(t, uint16(1), rawSpan.Tags["sampling.priority"]) | ||
| assertEqual(t, true, rawSpan.Tags["error"]) | ||
| } | ||
|
|
||
| // noopTracer and noopSpan with span tags implemented | ||
| type noopTracer struct{} |
|
Basically LGTM. Would you be up for sending out the trivial change to support this in |
| @@ -87,6 +87,14 @@ type Span interface { | |||
| // See the `SetBaggageItem` notes about `restrictedKey`. | |||
| BaggageItem(restrictedKey string) string | |||
|
|
|||
| // ForeachBaggageItem allows reading all baggage items stored in the span. | |||
There was a problem hiding this comment.
Is it worth documenting whether ForeachBaggageItem has a stable iteration order, or if the order can differ between consecutive calls of ForeachBaggageItem?
|
LGTM, thanks. |
This was referenced Jul 3, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bensigelman