Remove excessive zoom changes when changing stops in Stop Viewer #900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n viewed stop changes.
miles-grant-ibigroup
approved these changes
May 15, 2023
daniel-heppner-ibigroup
approved these changes
May 15, 2023
daniel-heppner-ibigroup
assigned
binh-dam-ibigroup and unassigned
daniel-heppner-ibigroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes map panning smoother when changing the viewed stop in the Stop Viewer (either by clicking a nearby stop in the main pane, or by clicking Stop Viewer from the map or itinerary leg in the narrative).
Basically, the
ConnectedStopViewerOverlaycomponent is competing with the stop fetching actions, causing hiccups in the map animation when switching stops.PR Checklist