Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mixer overflow #7747

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Fix mixer overflow #7747

merged 1 commit into from
Jun 17, 2020

Conversation

dgatf
Copy link
Contributor

@dgatf dgatf commented Jun 17, 2020

Fixes mixer overflow #7623 by limiting the chans values when fading flightmodes

Added two non regresion tests for mixer modes transitions:

  • flightModeOverflow evaluates the initial overflow error (where current mixer fails)
  • flightModeTransition evaluates the transition between two values (where dynamic bit shift fails)

@@ -65,6 +65,7 @@ inline void MODEL_RESET()
memset(&anaInValues, 0, sizeof(anaInValues));
extern uint8_t s_mixer_first_run_done;
s_mixer_first_run_done = false;
evalMixes(1); // this is needed to reset fp_act
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed to reset static variable fp_act

@dgatf dgatf requested a review from bsongis June 17, 2020 09:27
@dgatf dgatf linked an issue Jun 17, 2020 that may be closed by this pull request
@bsongis bsongis merged commit fca11fc into 2.3 Jun 17, 2020
@bsongis bsongis deleted the dgatf/flight_modes_transition branch June 17, 2020 13:55
ajjjjjjjj added a commit to OpenI6X/opentx that referenced this pull request Oct 25, 2022
- Fix mixer overflow (backport opentx#7747)
- Bars inverse (backport opentx#7709)
- Fix scale and telemetry fields (backport opentx#7704)
Cosmetics
ajjjjjjjj added a commit to OpenI6X/opentx that referenced this pull request Oct 25, 2022
- Remove module choice from special function set failsafe (backport opentx#8156)
- Fix mixer overflow (backport opentx#7747)
- Bars inverse (backport opentx#7709)
- Fix scale and telemetry fields (backport opentx#7704)
Cosmetics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flight mode transition bug
2 participants